Normalize core-js entry points
#9752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10586/ |
danez
added
PR: Bug Fix 🐛
danez
approved these changes
Mar 23, 2019
| @@ -21,6 +21,9 @@ function isBabelPolyfillSource(source) { | |||
| } | |||
|
|
|||
| function isCoreJSSource(source) { | |||
| if (typeof source === "string") { | |||
| source = source.replace(/(\/(index)?)?(\.js)?$/i, "").toLowerCase(); | |||
There was a problem hiding this comment.
I don't think we should use i and toLoweCase, otherwise imports that work when transpiled stop working if they are left as-is.
There was a problem hiding this comment.
Mh maybe it is ok to normalize paths; it won't cause any bug.
There was a problem hiding this comment.
I don't care, it's not something principal for me.
nicolo-ribaudo
approved these changes
Mar 23, 2019
nicolo-ribaudo
requested changes
Mar 23, 2019
packages/babel-preset-env/src/polyfills/corejs3/entry-plugin.js
Outdated
Show resolved
Hide resolved
Co-Authored-By: zloirock <zloirock@zloirock.ru>
nicolo-ribaudo
approved these changes
Mar 23, 2019
This was referenced Aug 17, 2019
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related this comment. Sorry, one more time from the main repo.