Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring back isPluginRequired #9709

Merged
merged 1 commit into from Mar 19, 2019
Merged

Bring back isPluginRequired #9709

merged 1 commit into from Mar 19, 2019

Conversation

nicolo-ribaudo
Copy link
Member

Q                       A
Fixed Issues? Fixes #9707
Patch: Bug Fix? Yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

@nicolo-ribaudo nicolo-ribaudo added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: preset-env labels Mar 19, 2019
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10537/

1 similar comment
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10537/

@ajanssens ajanssens mentioned this pull request Mar 19, 2019
Closed
@Turbo87
Copy link

Turbo87 commented Mar 19, 2019

@nicolo-ribaudo thanks for reacting on this so quickly! if the Ember CLI can help you test this or get it out quickly please let us know :)

@nicolo-ribaudo nicolo-ribaudo merged commit c548e78 into babel:master Mar 19, 2019
@nicolo-ribaudo nicolo-ribaudo deleted the ispluginrequired branch March 19, 2019 22:35
@nicolo-ribaudo
Copy link
Member Author

@Turbo87 Since the method hasn't been changed (but only accidentally removed), I don't think that we need anything else 🙂
I'll release a new version in ~12 hours, to give people time to report other possible regressions.

@Turbo87
Copy link

Turbo87 commented Mar 19, 2019

I'll release a new version in ~12 hours, to give people time to report other possible regressions.

would it be possible to get this out a little quicker? right now, it looks like ember-cli and vue-cli are not working at all when generating new projects that don't have lockfiles with older preset-env versions yet 😢

@nicolo-ribaudo
Copy link
Member Author

Done

@Turbo87
Copy link

Turbo87 commented Mar 19, 2019

awesome, thanks a lot! 😍

@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danez danez danez approved these changes

@hzoo hzoo hzoo approved these changes

Assignees
No one assigned
Labels
i: regression outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: preset-env PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

breaking change in @babel/preset-env 7.4.0
5 participants
@nicolo-ribaudo @babel-bot @Turbo87 @danez @hzoo