Fix compatibility between estree and TS plugin #9700
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the typescript plugin to parse literals in a way that the estree plugin can correctly convert them.
This also has one breaking changes:
This was parsed as
now it is
To me this was simply wrong because estree never defines numeric literals with negative values and we nowhere do this for the BabelLiterals. Not sure if this would be okay to go into a minor version. For what it's worth
typescript
andeslint-typescript
also parses it this way.