New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor parsing object members #9607
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danez
added
PR: Spec Compliance 👓
A type of pull request used for our changelog categories
pkg: parser
labels
Feb 28, 2019
danez
added this to In progress
in Parser: Spec Compliance, Refactoring and Performance
via automation
Feb 28, 2019
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10340/ |
Could you add some tests for these two points? (Unless I just missed them) |
I added a test for the async-newline stuff. The RestElement has already tests. It is all the tests that switched from throwing |
Parser: Spec Compliance, Refactoring and Performance
automation
moved this from In progress
to Reviewed
Feb 28, 2019
nicolo-ribaudo
approved these changes
Feb 28, 2019
existentialism
approved these changes
Feb 28, 2019
Parser: Spec Compliance, Refactoring and Performance
automation
moved this from Reviewed
to Done
Feb 28, 2019
lock
bot
added
the
outdated
A closed issue/PR that is archived due to age. Recommended to make a new issue
label
Oct 4, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
outdated
A closed issue/PR that is archived due to age. Recommended to make a new issue
pkg: parser
PR: Spec Compliance 👓
A type of pull request used for our changelog categories
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes some changes around destructuring, restspread and objects.
parseObj()
-loop intoparseObjectMember
.RestElement
inparseObjectMember
not withparseSpread() + toAssignable()
as that seems an overkill if we can parse it directly.RestElement
inparseObjectMember
not withparseRest()
as only Identifier is allowed in this context__proto__
. The spec specifically says only duplicates which come from the form*PropertyDefinition: PropertyName : AssignmentExpression*
: https://www.ecma-international.org/ecma-262/9.0/index.html#sec-__proto__-property-names-in-object-initializers"Rest element must be last element"
This makes the code a little bit simplerparseRest()
toparseRestBinding()