Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scope check for 2nd+ lexical bindings #9600

Merged
merged 1 commit into from Feb 27, 2019
Merged

Fix scope check for 2nd+ lexical bindings #9600

merged 1 commit into from Feb 27, 2019

Conversation

danez
Copy link
Member

@danez danez commented Feb 27, 2019 •
edited

Q                       A
Fixed Issues?
Patch: Bug Fix? y
Major: Breaking Change? n
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

The scope.lexical[0] === name is only meant for the catch checks.

@danez danez added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: parser labels Feb 27, 2019
@danez danez added this to In progress in Parser: Spec Compliance, Refactoring and Performance via automation Feb 27, 2019
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10325/

nicolo-ribaudo
nicolo-ribaudo approved these changes Feb 27, 2019
View reviewed changes
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I thought that it was just formatted by prettier in two lines 🤦‍♂️

Parser: Spec Compliance, Refactoring and Performance automation moved this from In progress to Reviewed Feb 27, 2019
@danez danez merged commit 5cb280f into babel:master Feb 27, 2019
Parser: Spec Compliance, Refactoring and Performance automation moved this from Reviewed to Done Feb 27, 2019
@danez danez deleted the dupl-2-lvl branch February 27, 2019 23:53
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
No open projects
Parser: Spec Compliance, Refactoring ...
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@danez @babel-bot @existentialism @nicolo-ribaudo