Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow duplicate params in methods #9599

Merged
merged 2 commits into from Feb 27, 2019
Merged

Disallow duplicate params in methods #9599

merged 2 commits into from Feb 27, 2019

Conversation

danez
Copy link
Member

@danez danez commented Feb 27, 2019

Q                       A
Fixed Issues?
Patch: Bug Fix? y
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

https://www.ecma-international.org/ecma-262/9.0/#sec-function-definitions-static-semantics-early-errors

UniqueFormalParameters: FormalParameters

  • It is a Syntax Error if BoundNames of FormalParameters contains any
    duplicate elements.

@danez danez added PR: Spec Compliance 👓 A type of pull request used for our changelog categories pkg: parser labels Feb 27, 2019
@danez danez added this to In progress in Parser: Spec Compliance, Refactoring and Performance via automation Feb 27, 2019
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10324/

1 similar comment
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10324/

Parser: Spec Compliance, Refactoring and Performance automation moved this from In progress to Reviewed Feb 27, 2019
@danez danez merged commit 208195f into babel:master Feb 27, 2019
Parser: Spec Compliance, Refactoring and Performance automation moved this from Reviewed to Done Feb 27, 2019
@danez danez deleted the duplicate-params branch February 27, 2019 23:54
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Spec Compliance 👓 A type of pull request used for our changelog categories
Projects
No open projects
Parser: Spec Compliance, Refactoring ...
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@danez @babel-bot @existentialism @nicolo-ribaudo