TypeScript Constant contexts #9534
Conversation
tanhauhau
commented
Feb 18, 2019
tanhauhau
commented
| Q | A |
|---|---|
| Fixed Issues? | Fixes #9502 |
| Patch: Bug Fix? | |
| Major: Breaking Change? | |
| Minor: New Feature? | |
| Tests Added + Pass? | Yes |
| Documentation PR Link | |
| Any Dependency Changes? | |
| License | MIT |
tanhauhau
changed the title
packages/babel-parser/test/fixtures/typescript/cast/as-const-2/input.js
Outdated
Show resolved
Hide resolved
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10453/ |
|
Looks very promising, let us know when you are done. |
danez
added
PR: WIP
pkg: parser
area: typescript
PR: Spec Compliance 👓
tanhauhau
changed the title
|
@danez it's ready for code review 😄 |
| case "UnaryExpression": | ||
| return this.tsCheckLiteralForConstantContext(node.argument); | ||
| default: | ||
| throw this.unexpected(node.start); |
There was a problem hiding this comment.
We can throw better error messages 😉
| throw this.unexpected(node.start); | |
| this.raise(node.start, "Only literal values are allowed in constant contexts"); |
| case "NumericLiteral": | ||
| case "BooleanLiteral": | ||
| case "ObjectExpression": | ||
| case "ArrayExpression": |
There was a problem hiding this comment.
For arrays and objects, don't we need to check their children?
e.g.
[ foo() ] as constThere was a problem hiding this comment.
updated and added new test case
| // but need `tsInType` to satisfy the assertion in `tsParseType`. | ||
| node.typeAnnotation = this.tsInType(() => this.tsParseType()); | ||
| const _const = this.tsTryNextParseConstantContext(); | ||
| node.typeAnnotation = _const ? _const : this.tsNextThenParseType(); |
There was a problem hiding this comment.
| node.typeAnnotation = _const ? _const : this.tsNextThenParseType(); | |
| node.typeAnnotation = _const || this.tsNextThenParseType(); |
tanhauhau
force-pushed
the
tanhauhau/parser-typescript-as-const
branch
from
cc8eb28
to
76f1c61
Compare
| let o5 = { ...o4 } as const; | ||
| let o6 = { ...o5 }; | ||
| let o7 = { ...d } as const; | ||
| let o8 = { ...o7 }; |
There was a problem hiding this comment.
What are these tests without as const needed for? I think that you copied them from https://github.com/Microsoft/TypeScript/blob/08fe06f5275bae91a2b2d7eb6387218b95ce3566/tests/baselines/reference/constAssertions.js, but since Babel doesn't type-check they aren't needed.
There was a problem hiding this comment.
Updated the test cases
|
Some tests are failing on travis/circle because of regenerator, but they will work if you rebase this PR on master. |
tanhauhau
force-pushed
the
tanhauhau/parser-typescript-as-const
branch
from
76f1c61
to
735d539
Compare
|
@nicolo-ribaudo cool. |
|
You also need to update the output 😛 |
tanhauhau
force-pushed
the
tanhauhau/parser-typescript-as-const
branch
from
3acf446
to
fcb060f
Compare
nicolo-ribaudo
added
PR: Ready to be Merged
lock
bot
added
the
outdated
