Fix regression with let #9477
Merged
Fix regression with let #9477
+728
−242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danez
added
PR: Bug Fix 🐛
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10018/ |
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10014/ |
nicolo-ribaudo
approved these changes
Feb 8, 2019
| case tt._class: | ||
| if (!declaration) this.unexpected(); | ||
| if (context) this.unexpected(); |
There was a problem hiding this comment.
As a side note, Function declaration is not allowed in this context is much nicer 😄
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the regression in 3.7.2 with let in certain cases and also allows a lot more new valid cases with functions (see test262 whitelist). This was backported from my branch which includes proper scope tracking. This is also the reason I did not care about good error messages here, as the code involving them will change anyway.