Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Private Static Class Methods (Stage 3) #9446

Merged
merged 9 commits into from Mar 12, 2019
Merged

Private Static Class Methods (Stage 3) #9446

merged 9 commits into from Mar 12, 2019

Conversation

tim-mc
Copy link
Contributor

@tim-mc tim-mc commented Feb 2, 2019 •
edited

Q                       A
Fixed Issues? babel/proposals#55
Patch: Bug Fix? --
Major: Breaking Change? --
Minor: New Feature? Add private static class method support
Tests Added + Pass? WIP
Documentation PR Link
Any Dependency Changes? No
License MIT

cc @robpalme @nicolo-ribaudo @littledan

@babel-bot
Copy link
Collaborator

babel-bot commented Feb 2, 2019 •
edited

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10419/

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9967/

@tim-mc
Copy link
Contributor Author

tim-mc commented Feb 2, 2019

@nicolo-ribaudo should this be considered a part of the babel-plugin-proposal-private-methods package?

@nicolo-ribaudo
Copy link
Member

I'd say yes, but let's also wait for @littledan 's opinion.

@nicolo-ribaudo nicolo-ribaudo mentioned this pull request Feb 4, 2019
Closed
@nicolo-ribaudo nicolo-ribaudo added PR: New Feature 🚀 A type of pull request used for our changelog categories Spec: Private Methods labels Feb 4, 2019
@nicolo-ribaudo nicolo-ribaudo added this to In progress in Class features via automation Feb 4, 2019
@littledan
Copy link

Yes, I would include it in the private methods package. (If anyone has concerns, please let me know and I can provide more detailed rationale.)

@nicolo-ribaudo nicolo-ribaudo added this to the v7.4.0 milestone Feb 11, 2019
@nicolo-ribaudo nicolo-ribaudo removed this from the v7.4.0 milestone Feb 18, 2019
@tim-mc
Copy link
Contributor Author

tim-mc commented Feb 22, 2019 •
edited

I've incorporated changes from #9508 into my PR since it solves a problem I ran into with handling supers.

@tim-mc tim-mc force-pushed the private-static-methods branch 2 times, most recently from 060980b to 22784fe Compare February 23, 2019 23:51
@tim-mc tim-mc changed the title [WIP] Private Static Class Methods (Stage 3) Private Static Class Methods (Stage 3) Feb 23, 2019
@tim-mc
Copy link
Contributor Author

tim-mc commented Feb 23, 2019

Support for both spec and loose modes have now been added. I'll see if I can figure out any more necessary test cases, but I think the PR is ready to start reviewing at this point. cc: @nicolo-ribaudo

Keep in mind that un-merged changes from #9508 are present in this PR as well.

@nicolo-ribaudo
Copy link
Member

I have merged #9508

@tim-mc
Copy link
Contributor Author

tim-mc commented Feb 24, 2019

@nicolo-ribaudo thanks, updated.

@nicolo-ribaudo nicolo-ribaudo added the PR: Needs Review A pull request awaiting more approvals label Mar 4, 2019
@buildsize
Copy link

buildsize bot commented Mar 7, 2019

File name Previous Size New Size Change
babel-preset-env.js [new file] 2.04 MB
babel-preset-env.min.js [new file] 1.09 MB
babel.js [new file] 2.76 MB
babel.min.js [new file] 1.54 MB

@tim-mc
Copy link
Contributor Author

tim-mc commented Mar 7, 2019

Erm... not sure why this happened

@nicolo-ribaudo
Copy link
Member

We enabled it to avoid size regressions but it doesn't work well after rebases.

jridgewell
jridgewell approved these changes Mar 12, 2019
View reviewed changes
Copy link
Member

@jridgewell jridgewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tim-mc
Copy link
Contributor Author

tim-mc commented Mar 12, 2019

I removed the "WIP" comment from the description. The PR is ready on my end.

@nicolo-ribaudo nicolo-ribaudo added this to the v7.4.0 milestone Mar 12, 2019
@nicolo-ribaudo nicolo-ribaudo removed the PR: Needs Review A pull request awaiting more approvals label Mar 12, 2019
@nicolo-ribaudo nicolo-ribaudo merged commit 81c130f into babel:master Mar 12, 2019
Class features automation moved this from In progress to Done Mar 12, 2019
@nicolo-ribaudo
Copy link
Member

Thank you!

This was referenced Mar 13, 2019
Closed
Open
mAAdhaTTah added a commit to mAAdhaTTah/babel that referenced this pull request Mar 15, 2019
@mAAdhaTTah
Merge branch 'master' into implement-f#-pipeline-in-parser
7458063 
* master: (58 commits)
  Remove dependency on home-or-tmp package (babel#9678)
  [proposal-object-rest-spread] fix templateLiteral in extractNormalizedKeys (babel#9628)
  Partial application plugin (babel#9474)
  Private Static Class Methods (Stage 3) (babel#9446)
  gulp-uglify@3.0.2
  rollup@1.6.0
  eslint@5.15.1
  jest@24.5.0
  regexpu-core@4.5.4
  Remove input and length from state (babel#9646)
  Switch from rollup-stream to rollup and update deps (babel#9640)
  System modules - Hoist classes like other variables (babel#9639)
  fix: Don't transpile ES2018 symbol properties (babel#9650)
  Add WarningsToErrorsPlugin to webpack to avoid missing build problems on CI (babel#9647)
  Update regexpu-core dependency (babel#9642)
  Add placeholders support to @babel/types and @babel/generator (babel#9542)
  Generate plugins file
  Make babel-standalone an ESModule and enable flow (babel#9025)
  Reorganize token types and use a map for them (babel#9645)
  [TS] Allow context type annotation on getters/setters (babel#9641)
  ...
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jridgewell jridgewell jridgewell approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: New Feature 🚀 A type of pull request used for our changelog categories Spec: Private Methods
Projects
No open projects
Class features
  
Done
Milestone
v7.4.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tim-mc @babel-bot @nicolo-ribaudo @littledan @jridgewell