Make yield a contextual keyword #9400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danez
added
PR: Bug Fix 🐛
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9888/ |
nicolo-ribaudo
approved these changes
Jan 23, 2019
|
Thank you for all those parser PRs! |
danez
added this to In progress
in Parser: Spec Compliance, Refactoring and Performance
via automation
danez
moved this from In progress
to Reviewed
in Parser: Spec Compliance, Refactoring and Performance
Parser: Spec Compliance, Refactoring and Performance
automation
moved this from Reviewed
to Done
Jan 23, 2019
danez
added
PR: Spec Compliance 👓
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes yield a contextual keyword. This allows yield to be used in more cases as identifier where it is valid.
I also changed the error messages for invalid
yieldandawaitusages to be more clear.This also refactors where
awaitis parsed, so that we do not have to dothis.parseIdentifier(true /* liberal */)when anawaitcould be allowed. This was blocking proper reserved word and keyword checks.