Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use isClassPrivateMethod because it isn't supported in <7.2.0 #9121

Merged
merged 1 commit into from Dec 4, 2018
Merged

Don't use isClassPrivateMethod because it isn't supported in <7.2.0 #9121

merged 1 commit into from Dec 4, 2018

Conversation

nicolo-ribaudo
Copy link
Member

Q                       A
Fixed Issues? Fixes #9120
Patch: Bug Fix? 👍
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

@nicolo-ribaudo nicolo-ribaudo added PR: Bug Fix 🐛 A type of pull request used for our changelog categories i: regression labels Dec 3, 2018
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9526/

existentialism
existentialism approved these changes Dec 4, 2018
View reviewed changes
Copy link
Member

@existentialism existentialism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nicolo-ribaudo nicolo-ribaudo removed the request for review from loganfsmyth December 4, 2018 07:23
@nicolo-ribaudo
Copy link
Member Author

Tested with Babel 7.1.6, this PR fixes the issue 👍

@nicolo-ribaudo nicolo-ribaudo merged commit b927fb2 into babel:master Dec 4, 2018
@nicolo-ribaudo nicolo-ribaudo deleted the regression-9120 branch December 4, 2018 07:35
This was referenced Dec 4, 2018
Closed
Closed
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

@danez danez danez approved these changes

Assignees
No one assigned
Labels
i: regression outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

helper-create-class-features-plugin path.isClassPrivateMethod is not a function
4 participants
@nicolo-ribaudo @babel-bot @existentialism @danez