Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[decorators] Correctly insert _initialize(this) after super(). #8970

Merged
merged 3 commits into from Nov 7, 2018
Merged

[decorators] Correctly insert _initialize(this) after super(). #8970

merged 3 commits into from Nov 7, 2018

Commits on Nov 4, 2018

  1. [decorators] Correctly insert _initialize(this) after super(). 

    This commit fixes to problem:
1) After `super();` statements, `_initialize(this)` was inserted without
   a trailing semicolon.
2) `(0, super())` causes an infinite recursion.
    @nicolo-ribaudo
    nicolo-ribaudo committed Nov 4, 2018
    Copy the full SHA
    1e623dc View commit details
    Browse the repository at this point in the history

  2. Fix tests

    @nicolo-ribaudo
    nicolo-ribaudo committed Nov 4, 2018
    Copy the full SHA
    d0d9f65 View commit details
    Browse the repository at this point in the history

  3. Add test

    @nicolo-ribaudo
    nicolo-ribaudo committed Nov 4, 2018
    Copy the full SHA
    e4bc0d1 View commit details
    Browse the repository at this point in the history