Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update flow tests and fix underscore being a reserved type #8965

Closed
wants to merge 1 commit into from
Closed

Update flow tests and fix underscore being a reserved type #8965

wants to merge 1 commit into from

Conversation

danez
Copy link
Member

@danez danez commented Nov 2, 2018 •
edited

Q                       A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change? sort of, if _ was used as type name
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Additionally to #8883 this adds _ as reserved type name.

This also updates the flow test suite.

@danez danez added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: parser labels Nov 2, 2018
@babel-bot
Copy link
Collaborator

babel-bot commented Nov 2, 2018 •
edited

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9314/

@danez
Copy link
Member Author

danez commented Nov 3, 2018 •
edited

Opppsss, sorry I just saw that there is already #8883, I will remove duplications from this PR.

@danez danez mentioned this pull request Nov 3, 2018
Merged
@danez
Copy link
Member Author

danez commented Nov 5, 2018

Closing in favor of #8883

@danez danez closed this Nov 5, 2018
@existentialism existentialism deleted the flow-test branch November 5, 2018 20:47
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danez @babel-bot @existentialism