Fix es6.string.iterator mapping in babel-preset-env #8693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
existentialism
commented
Sep 12, 2018
existentialism
commented
| Q | A |
|---|---|
| Fixed Issues? | Fixes #8691 |
| Patch: Bug Fix? | Y |
| Major: Breaking Change? | N |
| Minor: New Feature? | N |
| Tests Added + Pass? | Yes |
| Documentation PR Link | |
| Any Dependency Changes? | |
| License | MIT |
existentialism
added
PR: Bug Fix 🐛
existentialism
force-pushed
the
issue8691
branch
from
73d5f05
to
930ae0e
Compare
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9106/ |
nicolo-ribaudo
approved these changes
Sep 12, 2018
| @@ -277,7 +277,7 @@ const es = { | |||
| "es6.string.from-code-point": "String static methods / String.fromCodePoint", | |||
| "es6.string.includes": "String.prototype methods / String.prototype.includes", | |||
| "es6.string.italics": "String.prototype HTML methods", | |||
| "es6.string.iterator": "String properties and methods / Property access on strings", | |||
| "es6.string.iterator": "String.prototype methods / String.prototype[Symbol.iterator]", | |||
There was a problem hiding this comment.
(I hate these human-readable feature names)
hzoo
approved these changes
Sep 14, 2018
This was referenced Sep 18, 2018
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.