Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typescript import elision #8666

Merged
merged 1 commit into from Sep 10, 2018

Conversation

Retsam
Copy link
Contributor

@Retsam Retsam commented Sep 10, 2018

Q                       A
Fixed Issues? N/A (No open issue that I've found)
Patch: Bug Fix? 👍
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Fixes an issue where babel-plugin-transform-typescript is not properly eliding its imports: if there is any unnamed import (e.g. import 'foo'), then it bailed out and does not properly elide the other imports in the file.

So, while this would correctly compile:

import { Foo } from "foo";

const foos = [] as Foo[];

to

const foos = [];

If an unnamed import was added, the Foo import would no longer be elided. So:

import "something";
import { Foo } from "foo";

const foos = [] as Foo[];

would compile to

import "something";
import { Foo } from "foo";

const foos = [];

@babel-bot
Copy link
Collaborator

babel-bot commented Sep 10, 2018

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9073/

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9071/

Fixes an issue where babel-plugin-transform-typescript is not properly eliding its imports: if there is any unnamed import (e.g. `import 'foo'`), then it bailed out and does not properly elide the other imports in the file.
@nicolo-ribaudo nicolo-ribaudo added PR: Bug Fix 🐛 A type of pull request used for our changelog categories area: typescript labels Sep 10, 2018
@existentialism existentialism merged commit 9ad8b2b into babel:master Sep 10, 2018
@Retsam Retsam deleted the Typescript-import-elison-fix branch September 14, 2018 17:51
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: typescript outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants