Fix version checks in .availableHelper and transform-runtime definitions. #8659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loganfsmyth
added
the
PR: Bug Fix 🐛
loganfsmyth
force-pushed
the
helper-versioning
branch
from
e8196ca
to
61ec957
Compare
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9062/ |
existentialism
approved these changes
Sep 10, 2018
nicolo-ribaudo
approved these changes
Sep 10, 2018
xtuc
approved these changes
Sep 10, 2018
|
Ok, I made |
loganfsmyth
added a commit
that referenced
this pull request
Sep 11, 2018
loganfsmyth
added a commit
that referenced
this pull request
Sep 11, 2018
This was referenced Sep 17, 2018
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1, Fixes #2The comments in the code pretty much explain why this change is needed. I think this is enough to fix the issue, but it's actually a little difficult to be 100% sure since I don't entirely trust
semveranymore.As noted by the changes in the tests, this is definitely something that we need to fix in order for things to function properly. On
7.0.0essentially any helper will show up as available, unfortunately.An alternative fix here would be to change
transform-runtimeandexternal-helpersto stop passing7.0.0-beta.0as their default version, but I think the approach here is better?Since we've landed so much and might just straight to 7.1.0, I'm actually tempted to branch and release a
7.0.1with just this applied on top, so people have more of a chance to get updated to a version with a functional.availableHelper(). On the fence there though.