Rewrite Hub as interface #8469
Rewrite Hub as interface #8469
Conversation
nicolo-ribaudo
added
PR: Breaking Change 💥
| code: string = ""; | ||
| inputMap: Object | null = null; | ||
|
|
||
| hub: HubInterface = { | ||
| // keep it for the usage in babel-core, ex: path.hub.file.opts.filename | ||
| file: this, |
There was a problem hiding this comment.
@loganfsmyth In the other PR you asked to keep file here, but I think that it can be removed? (people can already get it in visitors using this.file)
There was a problem hiding this comment.
@nicolo-ribaudo Yeah, my concern was avoiding breaking changes. I think my preference would still be to keep it at this point since we're already pretty close to release. I don't think we'd want it as part of the interface, but leaving it in the object is so easy. Can we leave it with a big comment saying that we should remove it in 8.x but it's being left for backward-compat with 6.x during 7.x's lifetime?
There was a problem hiding this comment.
Yes, let's avoid breaking things at this point.
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/8810/ |
lock
bot
added
the
outdated
Ref: #5050. Check #5047 for more details.