Fix class inheritance in IE10 #7969
Conversation
jridgewell
added
the
PR: Bug Fix 馃悰
| subClass.prototype = Object.create(superClass && superClass.prototype, { | ||
| constructor: { | ||
| value: subClass, | ||
| enumerable: false, |
There was a problem hiding this comment.
It could be better to omit enumerable: false just to not force sham implementations to throw, but this would only happen on IE<9 anyway.
There was a problem hiding this comment.
This is the spec inherits. I think changing it to be enumerable would break more people who use a for-in.
You can always use loose mode to support these IE9?
There was a problem hiding this comment.
I think they just mean that the default is already false anyway, so leaving it out doesn't make anything fail, but allows polyfills to be less agressive in requiring enumerability on older platforms.
|
|
||
| test() { | ||
| } | ||
| Object.defineProperty(Obj.prototype, 'test', { |
There was a problem hiding this comment.
I don't understand what caused this change. Any idea? It doesn't seem like this should be split off like this.
There was a problem hiding this comment.
This is the reason I filled #7771. jridgewell@ab403f3#diff-0cd85dd4813df0687b8938547953d585L24
test here will be set on the subclass, but the super defines a get test, so it'll throw.
| }; | ||
| _getPrototypeOf = Object.setPrototypeOf | ||
| ? Object.getPrototypeOf | ||
| : function _getPrototypeOf(o) { return o.__proto__; }; |
There was a problem hiding this comment.
I think I'd still want to fall back to Object.getPrototypeOf if __proto__ falsy, since that was the old behavior.
jridgewell
force-pushed
the
class-inheritance
branch
from
2ebaafb
to
ee384fe
Compare
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/8054/ |
| _getPrototypeOf = Object.getPrototypeOf; | ||
| } else { | ||
| _getPrototypeOf = function _getPrototypeOf(o) { | ||
| return o.__proto__; |
There was a problem hiding this comment.
I think my comment here was misinterpreted. My concern was that this does not preserve the behavior changed in https://github.com/babel/babel/pull/7675/files#diff-a6fddd06921a2b0da9eb1fb68cd794b9L14
Old super calls used to be (Foo.__proto__ || Object.getPrototypeOf(Foo)).call, but here we assume that __proto__ is the source of truth and will always have a value, instead of falling back to Object.getPrototypeOf of __proto__ is falsy.
There was a problem hiding this comment.
Wow, that was dyslexic of me. Fixed.
jridgewell
force-pushed
the
class-inheritance
branch
from
a1a1fe2
to
5e3306a
Compare
|
How soon can this be released? Meteor implemented a pretty nasty workaround for this, which I would love to revert before shipping Meteor 1.7. I would have reported the problem, but it looked like Babel had simply decided to drop support for IE10, so I didn't think you'd be open to it. |
|
@benjamn Likely tomorrow. What's your timetable for 1.7? |
|
Tomorrow is great. We're on RC 11 right now, but I think this is a good reason to wait a little longer! I'm giving a talk at Meteor Night next Wednesday, with a call-to-action to update to Meteor 1.7, so we'd better release Meteor 1.7 before then, but I suppose we can just ship the workaround if the next Babel beta somehow doesn't get released by then. |
This reverts commit 8bfdea7. As clever as this IE10 hack may have been, it should no longer be necessary, thanks to babel/babel#7969. cc @abernix @hwillson
lock
bot
added
the
outdated
This reverts commit f8ab946, and unfixes #7771, because of IE 10. 馃槱
Also updates the
getPrototypeOfhelper according to #7965 (comment).Fixes #7892.
Fixes #7965.