Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up and add some additional polyfill mappings in preset-env #7809

Merged
merged 1 commit into from
May 10, 2018

Conversation

existentialism
Copy link
Member

@existentialism existentialism commented Apr 25, 2018

Q                       A
Fixed Issues? Fixes #5978
Patch: Bug Fix? y
Major: Breaking Change? n
Minor: New Feature? n
Tests Added + Pass? y/y
Documentation PR
Any Dependency Changes?
License MIT

Depends on #7808.

This PR tweaks/fixes/adds a number of polyfill-to-compat-table mappings and merges them into a single collection.

This should make the eventual upgrade to core-js@3 a bit easier to read (#7646) as it should be a lot of es7.* -> es.*.

All the credit goes to @zloirock.

@existentialism existentialism added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: preset-env labels Apr 25, 2018
@babel-bot
Copy link
Collaborator

babel-bot commented Apr 25, 2018

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/7873/

"es6.array.for-each": "Array methods / Array.prototype.forEach",
"es6.array.from": "Array static methods / Array.from",
"es6.array.includes": "Array.prototype.includes / Array.prototype.includes",
"es7.array.includes": "Array.prototype.includes",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • "es6.array.includes": "Array.prototype.includes / Array.prototype.includes",
  • "es7.array.includes": "Array.prototype.includes",

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

es6.array.includes just missed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@existentialism existentialism merged commit ee1ee0e into master May 10, 2018
@existentialism existentialism deleted the env-merge-builtins branch May 10, 2018 14:09
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: preset-env PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RegExp constructor to support copying other regex objects
4 participants