Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve import binding locations during module rewriting #7378

Merged
merged 3 commits into from Feb 14, 2018

Conversation

loganfsmyth
Copy link
Member

Q                       A
Fixed Issues?
Patch: Bug Fix? Y
Major: Breaking Change? N
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR
Any Dependency Changes?
License MIT

Similar to #7312, but for import variables.

@babel-bot
Copy link
Collaborator

babel-bot commented Feb 14, 2018

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/6879/

@hzoo hzoo added the PR: Bug Fix 🐛 A type of pull request used for our changelog categories label Feb 14, 2018
@loganfsmyth loganfsmyth merged commit e732ee0 into babel:master Feb 14, 2018
@loganfsmyth loganfsmyth deleted the import-mapping-fixes branch February 14, 2018 18:17
aminmarashi pushed a commit to aminmarashi/babel that referenced this pull request Mar 17, 2018
* Only wrap import references that need it.

* Preserve the import binding location for sourcemaps.

* Add tests.
loganfsmyth added a commit to loganfsmyth/babel that referenced this pull request Apr 25, 2018
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants