Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport fix from 7.x - wrong replace transform defautExports #6099

Closed
wants to merge 1 commit into from

Conversation

diervo
Copy link
Contributor

@diervo diervo commented Aug 13, 2017

Fixes:
rollup/rollup-plugin-babel#155 which in turn fixes the ability to build babily(master)

All info is in the link above.

Until this gets merged, everyone using rollup-plugin-babel with peer dependency on 6.x will be broken.

Fixes: rollup/rollup-plugin-babel#155 which in turn fixes the ability to build babily(master)
@mention-bot
Copy link

@diervo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @hzoo, @loganfsmyth and @jridgewell to be potential reviewers.

@diervo diervo changed the title Backport fix from 7.x Backport fix from 7.x - wrong replace transform defautExports Aug 13, 2017
@nicolo-ribaudo
Copy link
Member

nicolo-ribaudo commented Aug 13, 2017

Hi, some ours ago on slack we discussed about this bug: fixing it in babel would not fix the regression, since rollup-plugin-babel still wouldn't with Babel <= 6.25.0.
@loganfsmyth suggested to fix it in rollup-plugin-babel, checking replacing the ClassDeclaration#parentPath instead of the class itself if it is an ExportDefaultDeclaration.
https://github.com/rollup/rollup-plugin-babel/blob/3cc04d98d4045520467f3466755bc18cf213880f/src/helperPlugin.js#L5

@diervo
Copy link
Contributor Author

diervo commented Aug 13, 2017

Well that's why minor versions exist right? :)
Adding the workaround in rollup-plugin-babel seems much more dirty to me.

@nicolo-ribaudo
Copy link
Member

The problem is that rollup-plugin-babel has "babel-core": "6 || 7" as a peer dependency, so it must work with every Babel 6 version. It actually did before rollup/rollup-plugin-babel#154, so it is a breaking change to drop support for Babel <= 6.25.0

@diervo
Copy link
Contributor Author

diervo commented Aug 13, 2017

Fair enough, but the I would argue that this PR is orthogonal and should be merged anyway as a backport from 7. Owners call, feel free to close it.

@hzoo
Copy link
Member

hzoo commented Aug 15, 2017

Made 3.0.2 via rollup/rollup-plugin-babel#158

@hzoo
Copy link
Member

hzoo commented Aug 15, 2017

Just going to close then

Thanks @diervo for the patch, sorry everyone for the trouble!

@hzoo hzoo closed this Aug 15, 2017
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants