Flow opaque type aliases #5990
Merged
Flow opaque type aliases #5990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danez
approved these changes
Jul 24, 2017
|
👍 Flow 0.51 is released with Flow-side support for opaque types. Excited for this to land! |
existentialism
added
area: flow
PR: Spec Compliance 👓
|
@jbrown215 yep, run that script! |
|
@existentialism Ran generate-interfaces and generate-babel-types-docs! :D excited! |
|
@existentialism should I not have run one of those scripts? travis build failed from one of the files changed by the script |
|
@jbrown215 just fyi, I pushed #6031 to fix the CI error! :) |
|
@existentialism thanks for the help! looks like tests are passing now :D |
existentialism
approved these changes
Aug 2, 2017
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for Flow's opaque type aliases. Babylon support was added in this PR: babel/babylon#643
Tests pass when using the current state of babylon's master branch. Backport for 6.x will come after this lands.
I tried to split my commits in a way that would make it easier to review. The first two are the only code changes I made, the rest are tests.
Q: I assume I probably should update the babel-types README to include declareOpaqueType and opaqueType, but I noticed all of the docs refer to
to.is__andt.assert__which only look like they are declared in an autogenerated file. Should I run that script myself?