Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hoist toSequenceExpression's convert helper (#5693) #5753

Merged
merged 1 commit into from May 20, 2017

Conversation

jridgewell
Copy link
Member

Q A
Patch: Bug Fix? Yes
Major: Breaking Change? No
Minor: New Feature? No?
Deprecations? No
Spec Compliancy? No
Tests Added/Pass? Lots
Fixed Tickets Fixes #5080, Fixes #4224
License MIT
Doc PR
Dependency Changes

Ports #5693 to 7.0.

@mention-bot
Copy link

@jridgewell, thanks for your PR! By analyzing the history of the files in this pull request, we identified @hzoo, @boopathi and @zertosh to be potential reviewers.

@codecov
Copy link

codecov bot commented May 19, 2017

Codecov Report

Merging #5753 into 7.0 will decrease coverage by 0.01%.
The diff coverage is 97.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##              7.0    #5753      +/-   ##
==========================================
- Coverage   84.61%   84.59%   -0.02%     
==========================================
  Files         282      282              
  Lines        9855     9857       +2     
  Branches     2766     2769       +3     
==========================================
  Hits         8339     8339              
- Misses        998     1003       +5     
+ Partials      518      515       -3
Impacted Files Coverage Δ
packages/babel-types/src/converters.js 95.23% <97.43%> (+2.82%) ⬆️
packages/babel-helper-call-delegate/src/index.js 64% <0%> (-4%) ⬇️
packages/babel-traverse/src/path/modification.js 72.11% <0%> (-0.97%) ⬇️
packages/babel-traverse/src/visitors.js 85.71% <0%> (-0.96%) ⬇️
packages/babel-traverse/src/path/context.js 85.34% <0%> (-0.87%) ⬇️
...bel-plugin-transform-es2015-classes/src/vanilla.js 90.12% <0%> (-0.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cd4a62...58216f5. Read the comment docs.

@jridgewell jridgewell merged commit 943fa8a into babel:7.0 May 20, 2017
@jridgewell jridgewell deleted the 7.0 branch May 20, 2017 01:54
@hzoo hzoo added the PR: Bug Fix 🐛 A type of pull request used for our changelog categories label May 20, 2017
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: perf outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants