Add test for arrow function inside generator #5595
Conversation
Update regenerator-transform to new version
|
Hey @yavorsky! It looks like one or more of your builds have failed. I've copied the relevant info below to save you some time. |
|
Looks like node 0.12 throw, but the point of this test is to run regenerator-transform w/o arrow function transformation 😟 |
|
Do you want your fix in the 6.0 branch? Because in 7.0 the support for Node 0.10 and 0.12 was removed. |
|
Arrow function syntax isn't available on Node 0.12, that's why it fails to parse. |
| @@ -0,0 +1,5 @@ | |||
| { | |||
| "plugins": [ | |||
| "transform-regenerator" | |||
There was a problem hiding this comment.
I'm trying to add a ES2015 presets (like here), currently not working for me
There was a problem hiding this comment.
es2015 will transform arrow function, so there is no sense in this test. The goal is test for generator with arrow function inside 🙂
There was a problem hiding this comment.
Sure, we should do a simple string comparaison here to avoid Node parsing it.
Codecov Report
@@ Coverage Diff @@
## 6.x #5595 +/- ##
==========================================
+ Coverage 84.43% 84.47% +0.04%
==========================================
Files 204 204
Lines 9599 9599
Branches 2696 2696
==========================================
+ Hits 8105 8109 +4
+ Misses 1007 1003 -4
Partials 487 487
Continue to review full report at Codecov.
|
|
If it's just the test, we can just merge this in 7.x, no need to backport |
lock
bot
added
the
outdated
Add test for arrow function inside generator (babel/babel-preset-env#160).