Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix commonjs exports with destructuring. #5469

Merged
merged 13 commits into from Jun 21, 2017
Merged

Fix commonjs exports with destructuring. #5469

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
f81d749
Fix exports while destructuring.
yavorsky Mar 15, 2017
9b410be
Add test for exports destructuring.
yavorsky Mar 15, 2017
0c2e3b1
Remove exports definition.
yavorsky Mar 15, 2017
b5bb89b
Add array pattern to exports destructuring.
yavorsky Mar 18, 2017
06f67e1
Consider default parameters for array pattern.
yavorsky Mar 18, 2017
b608e28
Consider rest params for array pattern in exports.
yavorsky Mar 18, 2017
45b4174
Consider default params for object pattern.
yavorsky Mar 18, 2017
c82b084
Fix object rest params for exports.
yavorsky Mar 18, 2017
18d6ba9
Fix export array rest expected output.
yavorsky Mar 18, 2017
c42e027
Add object rest spread syntax using plugin.
yavorsky Mar 19, 2017
7035401
Fix visitor inheritance.
yavorsky Mar 19, 2017
ddfb6f2
Remove object-rest-spread syntax.
yavorsky Mar 22, 2017
f2f226b
Add syntax-object-rest-spread as devDep for tests.
yavorsky Mar 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 9 additions & 0 deletions packages/babel-plugin-transform-es2015-modules-commonjs/src/index.js
View file
Open in desktop
Expand Up @@ -306,6 +306,15 @@ export default function () {
addTo(exports, id.node.name, id.node);
init.replaceWith(buildExportsAssignment(id.node, init.node).expression);
nonHoistedExportNames[id.node.name] = true;
} else if (id.isObjectPattern()) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be handling ArrayPattern too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@loganfsmyth Sure! Going to add. Thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could the ArrayPattern be a separate PR?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xtuc I've started work on it but could pick it out to a separate PR

for (let i = 0; i < id.node.properties.length; i++) {
const prop = id.node.properties[i];
if (!t.isRestProperty(prop)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the rest property also be handled?

for example

export const {foo: test, ...tester} = {};

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danez Probably yes, but for now: 1) we haven't envs to use it without transform-object-rest-spread and 2) seems like we need babel-plugin-syntax-object-rest-spread for rest properties: repl

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine for people to have enabled support for the syntax without enabling the actual transformation, so I think it would be good to handle.

addTo(exports, prop.value.name, prop.value);
path.insertAfter(buildExportsAssignment(prop.value, prop.value));
nonHoistedExportNames[prop.value.name] = true;
}
}
} else {
// todo
}
Expand Down
1 change: 1 addition & 0 deletions ...ansform-es2015-modules-commonjs/test/fixtures/strict/export-const-destructuring/actual.js
View file
Open in desktop
@@ -0,0 +1 @@
export const { foo: bar, baz } = {};
5 changes: 5 additions & 0 deletions ...sform-es2015-modules-commonjs/test/fixtures/strict/export-const-destructuring/expected.js
View file
Open in desktop
@@ -0,0 +1,5 @@
"use strict";

const { foo: bar, baz } = {};
exports.baz = baz;
exports.bar = bar;