Add test for options to babel-cli #5398

outsideris · 2017-03-01T13:42:59Z

Q	A
Patch: Bug Fix?	N
Major: Breaking Change?	N
Minor: New Feature?	N
Deprecations?
Spec Compliancy?
Tests Added/Pass?	Y
Fixed Tickets
License	MIT
Doc PR
Dependency Changes

It's tests for babel-cli's options, see the coverrage.

babel-bot · 2017-03-04T18:10:37Z

Hey @outsideris! It looks like one or more of your builds have failed. I've copied the relevant info below to save you some time.

outsideris · 2017-03-05T08:35:12Z

I'm stuck here.

Node v4 doesn't support --inspect. How can I handle it?
The tests were passed in Node v7, but nyc which is for coverage looks like doesn't support debug options.

Also, I tried to add tests for --d, --debug and --debug-brk. But it is hard to make tests for them because these flags are hanging in debug console.

xtuc · 2017-03-05T16:22:42Z

If the test can't run on Node v4 I would skip it, like:

it('foo', function() {
  if (getMajorVersion(process.version) === 4) {
    this.skip();
  }

});

babel-bot · 2017-03-06T17:35:28Z

Hey @outsideris! It looks like one or more of your builds have failed. I've copied the relevant info below to save you some time.

babel-bot · 2017-03-06T17:50:56Z

Hey @outsideris! It looks like one or more of your builds have failed. I've copied the relevant info below to save you some time.

codecov · 2017-03-12T11:21:38Z

Codecov Report

Merging #5398 into 7.0 will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              7.0    #5398      +/-   ##
==========================================
+ Coverage   85.24%   85.29%   +0.05%     
==========================================
  Files         284      284              
  Lines        9958     9958              
  Branches     2780     2780              
==========================================
+ Hits         8489     8494       +5     
+ Misses        968      963       -5     
  Partials      501      501

Impacted Files	Coverage Δ
packages/babel-helper-call-delegate/src/index.js	`64% <0%> (-4%)`	⬇️
packages/babel-traverse/src/path/modification.js	`72.11% <0%> (-0.97%)`	⬇️
packages/babel-traverse/src/visitors.js	`85.71% <0%> (-0.96%)`	⬇️
packages/babel-traverse/src/path/context.js	`85.34% <0%> (-0.87%)`	⬇️
...bel-plugin-transform-es2015-classes/src/vanilla.js	`90.21% <0%> (-0.43%)`	⬇️
packages/babel-cli/src/babel-node.js	`68.08% <0%> (+21.27%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 070662e...1cee0e9. Read the comment docs.

outsideris · 2017-03-12T11:51:08Z

I removed a test for a debug option, because there is an error with nyc.

outsideris · 2017-03-12T11:54:03Z

packages/babel-cli/test/index.js

@@ -174,7 +174,9 @@ fs.readdirSync(fixtureLoc).forEach(function (binName) {
        opts.inFiles[".babelrc"] = helper.readFile(babelrcLoc);
      }

-      it(testName, buildTest(binName, testName, opts));
+      if (testName !== "flag-dashed-inspect" || !process.version.match(/^v[045]/)) {


I want to exclude the test for --inspect in Node v0.12, v4 and v5.
I doesn't like this workaround, but I couldn't find better way.

We recently landed #5765, which allows you to specify a minimum node.js version via minNodeVersion

existentialism · 2017-05-31T00:47:37Z

@outsideris sorry for the delay on this, but let's revive this as we landed #5785 and should probably get some test coverage around this.

xtuc · 2017-05-31T06:46:39Z

@existentialism I changed the label because you set (by mistake?) the documentation one.

outsideris · 2017-06-11T13:01:06Z

I'm trying to fix it and change the base branch to 7.0.
However although I specify minNodeVersion, it failed in Node v4
I missed something? @existentialism

babel-bot · 2017-09-15T02:08:20Z

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/4907/

jridgewell · 2017-09-15T02:11:16Z

I think minNodeVersion only work in fixture tests, not babel-cli tests.

outsideris · 2017-10-05T06:43:37Z

So, how can I solve it?

outsideris force-pushed the test-for-bable-cli branch from 123db6b to 464ad19 Compare March 4, 2017 18:05

outsideris changed the base branch from 7.0 to master March 4, 2017 18:08

xtuc changed the title ~~Add test for options to bable-cli~~ Add test for options to babel-cli Mar 5, 2017

outsideris force-pushed the test-for-bable-cli branch from 464ad19 to 8d854f1 Compare March 6, 2017 17:28

outsideris force-pushed the test-for-bable-cli branch from 8d854f1 to a3df0b1 Compare March 6, 2017 17:44

outsideris force-pushed the test-for-bable-cli branch from a3df0b1 to f47874c Compare March 12, 2017 11:14

outsideris force-pushed the test-for-bable-cli branch from f47874c to ca010aa Compare March 12, 2017 11:24

outsideris commented Mar 12, 2017

View reviewed changes

existentialism added the PR: Docs 📝 A type of pull request used for our changelog categories label May 31, 2017

xtuc added area: tests and removed PR: Docs 📝 A type of pull request used for our changelog categories labels May 31, 2017

outsideris force-pushed the test-for-bable-cli branch from ca010aa to 6b8b508 Compare June 11, 2017 12:22

outsideris changed the base branch from master to 7.0 June 11, 2017 12:41

outsideris force-pushed the test-for-bable-cli branch from 6b8b508 to 8f096ad Compare June 11, 2017 12:45

outsideris force-pushed the test-for-bable-cli branch from 8f096ad to 1cee0e9 Compare June 11, 2017 13:03

danez closed this Aug 31, 2017

danez reopened this Aug 31, 2017

danez changed the base branch from 7.0 to master August 31, 2017 18:24

Add tests for options to babel-node

2a8851f

jridgewell force-pushed the test-for-bable-cli branch from 1cee0e9 to 2a8851f Compare September 15, 2017 01:56

nicolo-ribaudo self-assigned this Feb 14, 2019

nicolo-ribaudo mentioned this pull request Feb 14, 2019

Add tests for options to babel-node #9510

Merged

nicolo-ribaudo closed this in #9510 Feb 14, 2019

lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019

lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add test for options to babel-cli #5398

Add test for options to babel-cli #5398

outsideris commented Mar 1, 2017 •

edited

babel-bot commented Mar 4, 2017

outsideris commented Mar 5, 2017

xtuc commented Mar 5, 2017

babel-bot commented Mar 6, 2017

babel-bot commented Mar 6, 2017

codecov bot commented Mar 12, 2017 •

edited

outsideris commented Mar 12, 2017

outsideris Mar 12, 2017

existentialism May 31, 2017

existentialism commented May 31, 2017

xtuc commented May 31, 2017

outsideris commented Jun 11, 2017

babel-bot commented Sep 15, 2017 •

edited

jridgewell commented Sep 15, 2017

outsideris commented Oct 5, 2017

Add test for options to babel-cli #5398

Add test for options to babel-cli #5398

Conversation

outsideris commented Mar 1, 2017 • edited

babel-bot commented Mar 4, 2017

outsideris commented Mar 5, 2017

xtuc commented Mar 5, 2017

babel-bot commented Mar 6, 2017

babel-bot commented Mar 6, 2017

codecov bot commented Mar 12, 2017 • edited

Codecov Report

outsideris commented Mar 12, 2017

outsideris Mar 12, 2017

Choose a reason for hiding this comment

existentialism May 31, 2017

Choose a reason for hiding this comment

existentialism commented May 31, 2017

xtuc commented May 31, 2017

outsideris commented Jun 11, 2017

babel-bot commented Sep 15, 2017 • edited

jridgewell commented Sep 15, 2017

outsideris commented Oct 5, 2017

outsideris commented Mar 1, 2017 •

edited

codecov bot commented Mar 12, 2017 •

edited

babel-bot commented Sep 15, 2017 •

edited