Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the code coverage for traverse evaluation #5363

Merged
merged 3 commits into from Apr 9, 2017

Conversation

ssuman
Copy link
Contributor

@ssuman ssuman commented Feb 23, 2017

…on.js

Q A
Patch: Bug Fix? No
Major: Breaking Change? No
Minor: New Feature? No
Deprecations? No
Spec Compliancy? No
Tests Added/Pass? Yes
Fixed Tickets Fixes #1, Fixes #2
License MIT
Doc PR
Dependency Changes

Added few test cases to increase the code coverage for evaluation.js

@mention-bot
Copy link

@ssuman, thanks for your PR! By analyzing the history of the files in this pull request, we identified @DrewML, @boopathi and @loganfsmyth to be potential reviewers.

@babel-bot
Copy link
Collaborator

Hey @ssuman! It looks like one or more of your builds have failed. I've copied the relevant info below to save you some time.

@codecov
Copy link

codecov bot commented Feb 23, 2017

Codecov Report

Merging #5363 into master will increase coverage by 0.23%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5363      +/-   ##
==========================================
+ Coverage   84.49%   84.73%   +0.23%     
==========================================
  Files         204      204              
  Lines        9597     9597              
  Branches     2695     2695              
==========================================
+ Hits         8109     8132      +23     
+ Misses       1001      977      -24     
- Partials      487      488       +1
Impacted Files Coverage Δ
packages/babel-traverse/src/visitors.js 85.71% <0%> (-0.96%)
packages/babel-traverse/src/path/context.js 86.2% <0%> (-0.87%)
...bel-plugin-transform-es2015-classes/src/vanilla.js 90.59% <0%> (+0.42%)
packages/babel-traverse/src/path/evaluation.js 81.53% <0%> (+12.3%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71e4336...65ce35c. Read the comment docs.

@ssuman
Copy link
Contributor Author

ssuman commented Feb 24, 2017

@loganfsmyth This is my first PR. Please let me know if any changes are required.

@xtuc xtuc added PR: Internal 🏠 A type of pull request used for our changelog categories area: tests labels Feb 25, 2017
@loganfsmyth loganfsmyth merged commit 412180e into babel:master Apr 9, 2017
pwmckenna pushed a commit to pwmckenna/babel that referenced this pull request Apr 26, 2017
* When applied this commit will increase the code coverage for evaluation.js

* Fixing linting issues
hulkish added a commit to hulkish/babel that referenced this pull request May 2, 2017
* 'master' of github.com:hulkish/babel: (37 commits)
  Increase the code coverage for traverse evaluation (babel#5363)
  Improve options documentation for `babel-plugin-transform-runtime` babel#5401
  [doc] Fix: comments in usage w/ options babel#5400
  document cache option for babel-register babel#5440
  Update coffescript/register reference link address babel#5475
  Update babel-generator's README babel#5517
  Improve example of babel-plugin-transform-es2015-arrow-functions babel#5573
  Remove incorrect docs. babel#5580
  Update transform-es2015-modules-commonjs doc babel#5588
  Fix replacing function declaration in export default (fixes babel#4468) (babel#5456)
  Fix a typo: occurences -> occurrences (babel#5575)
  Fix changelog [skip ci]
  Treat "await" as an invalid identifier (babel#4954)
  Removes unused lodash dependency from babel-helper-builder-react-jsx (babel#5486)
  docs: [skip ci] update documentation
  v6.24.0
  changelog for 6.24.0 [skip ci] (babel#5452)
  Keep parentheses for logical expression when in await expression (fix babel#5428) (babel#5433) (babel#5453)
  Use absolute paths in Babel's CONTRIBUTING.md (babel#5431)
  Fixed broken links in README.md [skip ci] (babel#5449)
  ...
hulkish pushed a commit to hulkish/babel that referenced this pull request May 3, 2017
* When applied this commit will increase the code coverage for evaluation.js

* Fixing linting issues
jridgewell pushed a commit to jridgewell/babel that referenced this pull request May 3, 2017
* When applied this commit will increase the code coverage for evaluation.js

* Fixing linting issues
jridgewell pushed a commit to jridgewell/babel that referenced this pull request May 6, 2017
* When applied this commit will increase the code coverage for evaluation.js

* Fixing linting issues
fforres pushed a commit to fforres/babel that referenced this pull request May 15, 2018
* When applied this commit will increase the code coverage for evaluation.js

* Fixing linting issues
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: tests outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants