Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loose for-of with label #5298

Merged
merged 1 commit into from Feb 13, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 12 additions & 6 deletions packages/babel-plugin-transform-es2015-for-of/src/index.js
Expand Up @@ -135,9 +135,8 @@ export default function ({ messages, template, types: t }) {
};

function loose(path, file) {
const { node, scope } = path;

const left = node.left;
const { node, scope, parent } = path;
const { left } = node;
let declar, id;

if (t.isIdentifier(left) || t.isPattern(left) || t.isMemberExpression(left)) {
Expand Down Expand Up @@ -171,11 +170,18 @@ export default function ({ messages, template, types: t }) {
}

//
const isLabeledParent = t.isLabeledStatement(parent);
let labeled;

if (isLabeledParent) {
labeled = t.labeledStatement(parent.label, loop);
}

return {
declar: declar,
node: loop,
loop: loop
replaceParent: isLabeledParent,
declar: declar,
node: labeled || loop,
loop: loop
};
}

Expand Down
@@ -0,0 +1,5 @@
b: for (let c of d()) {
for (let e of f()) {
continue b;
}
}
@@ -0,0 +1,31 @@
b: for (var _iterator = d(), _isArray = Array.isArray(_iterator), _i = 0, _iterator = _isArray ? _iterator : _iterator[Symbol.iterator]();;) {
var _ref;

if (_isArray) {
if (_i >= _iterator.length) break;
_ref = _iterator[_i++];
} else {
_i = _iterator.next();
if (_i.done) break;
_ref = _i.value;
}

let c = _ref;

for (var _iterator2 = f(), _isArray2 = Array.isArray(_iterator2), _i2 = 0, _iterator2 = _isArray2 ? _iterator2 : _iterator2[Symbol.iterator]();;) {
var _ref2;

if (_isArray2) {
if (_i2 >= _iterator2.length) break;
_ref2 = _iterator2[_i2++];
} else {
_i2 = _iterator2.next();
if (_i2.done) break;
_ref2 = _i2.value;
}

let e = _ref2;

continue b;
}
}