Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add our business model [skip ci] #5242

Merged
merged 1 commit into from Jan 30, 2017
Merged

Add our business model [skip ci] #5242

merged 1 commit into from Jan 30, 2017

Conversation

hzoo
Copy link
Member

@hzoo hzoo commented Jan 30, 2017 •
edited

screen shot 2017-01-29 at 11 51 25 pm

--

  • don't need to run tests for this one
Q A
Patch: Bug Fix? yes
Major: Breaking Change?
Minor: New Feature?
Deprecations?
Spec Compliancy?
Tests Added/Pass?
Fixed Tickets Fixes everything
License MIT
Doc PR
Dependency Changes

@hzoo
Add our business model [skip ci]
442ed83 
- don't need to run tests for this one
@hzoo hzoo added the PR: Docs 📝 A type of pull request used for our changelog categories label Jan 30, 2017
@MylesBorins
Copy link
Member

lgtm ship it

xtuc
xtuc approved these changes Jan 30, 2017
View reviewed changes
Copy link
Member

@xtuc xtuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 😄

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request head (business-model@442ed83).

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 510e93b...442ed83. Read the comment docs.

developit
developit approved these changes Jan 30, 2017
View reviewed changes
Copy link
Member

@developit developit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the most important change of 2017 so far

existentialism
existentialism approved these changes Jan 30, 2017
View reviewed changes
Copy link
Member

@existentialism existentialism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jamiebuilds jamiebuilds merged commit 2104ab6 into master Jan 30, 2017
@jamiebuilds jamiebuilds deleted the business-model branch January 30, 2017 17:28
existentialism pushed a commit that referenced this pull request May 19, 2017
@hzoo @existentialism
Add our business model [skip ci] (#5242)
d473d6b 
- don't need to run tests for this one
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

@developit developit developit approved these changes

@xtuc xtuc xtuc approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Docs 📝 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@hzoo @MylesBorins @codecov-io @existentialism @developit @xtuc @jamiebuilds