Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handling circular/shared structures in deep-clone #15366

Merged
merged 2 commits into from Feb 15, 2023
Merged

handling circular/shared structures in deep-clone #15366

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b1f7d88
handling circular structures in deep-clone
azizghuloum Jan 25, 2023
b4cb441
test
liuxingbaoyu Feb 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/babel-core/src/transformation/util/clone-deep.ts
View file
Open in desktop
Expand Up @@ -5,12 +5,14 @@ function deepClone(value: any, cache: Map<any, any>): any {
let cloned: any;
if (Array.isArray(value)) {
cloned = new Array(value.length);
cache.set(value, cloned);
for (let i = 0; i < value.length; i++) {
cloned[i] =
typeof value[i] !== "object" ? value[i] : deepClone(value[i], cache);
}
} else {
cloned = {};
cache.set(value, cloned);
const keys = Object.keys(value);
for (let i = 0; i < keys.length; i++) {
const key = keys[i];
Expand All @@ -20,7 +22,6 @@ function deepClone(value: any, cache: Map<any, any>): any {
: deepClone(value[key], cache);
}
}
cache.set(value, cloned);
return cloned;
}
return value;
Expand Down