New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse using[foo] as computed member expression
#15225
Merged
Merged
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
fa9b0e3
refactor: pack parseStatement flags
JLHwung 7058947
refactor: use const enum for parseFunctionFlags
JLHwung 23ac1c1
polish: avoid double error report on sloppy generator function
JLHwung f5115d6
refactor: move isAsync into ParseFunctionFlag
JLHwung 67194e4
refactor: simplify hasFollowingIdentifier
JLHwung 3d67382
fix: parse using[foo] as member expression
JLHwung 379c30e
remove Errors.UsingDeclarationHasBindingPattern
JLHwung bdb5e31
improve typings
JLHwung 43ac671
fix: add negative let [ lookahead for expression statement
JLHwung 20dd34c
fix: disallow labeled function within if
JLHwung 18eebaa
polish: improve error message for `if (0) let x`
JLHwung 7b949f4
tweak: remove default parameter
JLHwung b0f2cee
fix: avoid double report for labeled top level using
JLHwung File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 8 additions & 0 deletions
8
...es/experimental/explicit-resource-management/invalid-in-single-statement-context/input.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| { | ||
| while (1) using a; | ||
| for (;;) using b; | ||
| do using c; while (1); | ||
| if (1) using d; | ||
| with (1) using e; | ||
| label: using f; | ||
| } |
199 changes: 199 additions & 0 deletions
199
...experimental/explicit-resource-management/invalid-in-single-statement-context/output.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,199 @@ | ||
| { | ||
| "type": "File", | ||
| "start":0,"end":125,"loc":{"start":{"line":1,"column":0,"index":0},"end":{"line":8,"column":1,"index":125}}, | ||
| "errors": [ | ||
| "SyntaxError: Lexical declaration cannot appear in a single-statement context. (2:12)", | ||
| "SyntaxError: Lexical declaration cannot appear in a single-statement context. (3:11)", | ||
| "SyntaxError: Lexical declaration cannot appear in a single-statement context. (4:5)", | ||
| "SyntaxError: Lexical declaration cannot appear in a single-statement context. (5:9)", | ||
| "SyntaxError: Lexical declaration cannot appear in a single-statement context. (6:11)", | ||
| "SyntaxError: Lexical declaration cannot appear in a single-statement context. (7:9)" | ||
| ], | ||
| "program": { | ||
| "type": "Program", | ||
| "start":0,"end":125,"loc":{"start":{"line":1,"column":0,"index":0},"end":{"line":8,"column":1,"index":125}}, | ||
| "sourceType": "script", | ||
| "interpreter": null, | ||
| "body": [ | ||
| { | ||
| "type": "BlockStatement", | ||
| "start":0,"end":125,"loc":{"start":{"line":1,"column":0,"index":0},"end":{"line":8,"column":1,"index":125}}, | ||
| "body": [ | ||
| { | ||
| "type": "WhileStatement", | ||
| "start":4,"end":22,"loc":{"start":{"line":2,"column":2,"index":4},"end":{"line":2,"column":20,"index":22}}, | ||
| "test": { | ||
| "type": "NumericLiteral", | ||
| "start":11,"end":12,"loc":{"start":{"line":2,"column":9,"index":11},"end":{"line":2,"column":10,"index":12}}, | ||
| "extra": { | ||
| "rawValue": 1, | ||
| "raw": "1" | ||
| }, | ||
| "value": 1 | ||
| }, | ||
| "body": { | ||
| "type": "VariableDeclaration", | ||
| "start":14,"end":22,"loc":{"start":{"line":2,"column":12,"index":14},"end":{"line":2,"column":20,"index":22}}, | ||
| "declarations": [ | ||
| { | ||
| "type": "VariableDeclarator", | ||
| "start":20,"end":21,"loc":{"start":{"line":2,"column":18,"index":20},"end":{"line":2,"column":19,"index":21}}, | ||
| "id": { | ||
| "type": "Identifier", | ||
| "start":20,"end":21,"loc":{"start":{"line":2,"column":18,"index":20},"end":{"line":2,"column":19,"index":21},"identifierName":"a"}, | ||
| "name": "a" | ||
| }, | ||
| "init": null | ||
| } | ||
| ], | ||
| "kind": "using" | ||
| } | ||
| }, | ||
| { | ||
| "type": "ForStatement", | ||
| "start":25,"end":42,"loc":{"start":{"line":3,"column":2,"index":25},"end":{"line":3,"column":19,"index":42}}, | ||
| "init": null, | ||
| "test": null, | ||
| "update": null, | ||
| "body": { | ||
| "type": "VariableDeclaration", | ||
| "start":34,"end":42,"loc":{"start":{"line":3,"column":11,"index":34},"end":{"line":3,"column":19,"index":42}}, | ||
| "declarations": [ | ||
| { | ||
| "type": "VariableDeclarator", | ||
| "start":40,"end":41,"loc":{"start":{"line":3,"column":17,"index":40},"end":{"line":3,"column":18,"index":41}}, | ||
| "id": { | ||
| "type": "Identifier", | ||
| "start":40,"end":41,"loc":{"start":{"line":3,"column":17,"index":40},"end":{"line":3,"column":18,"index":41},"identifierName":"b"}, | ||
| "name": "b" | ||
| }, | ||
| "init": null | ||
| } | ||
| ], | ||
| "kind": "using" | ||
| } | ||
| }, | ||
| { | ||
| "type": "DoWhileStatement", | ||
| "start":45,"end":67,"loc":{"start":{"line":4,"column":2,"index":45},"end":{"line":4,"column":24,"index":67}}, | ||
| "body": { | ||
| "type": "VariableDeclaration", | ||
| "start":48,"end":56,"loc":{"start":{"line":4,"column":5,"index":48},"end":{"line":4,"column":13,"index":56}}, | ||
| "declarations": [ | ||
| { | ||
| "type": "VariableDeclarator", | ||
| "start":54,"end":55,"loc":{"start":{"line":4,"column":11,"index":54},"end":{"line":4,"column":12,"index":55}}, | ||
| "id": { | ||
| "type": "Identifier", | ||
| "start":54,"end":55,"loc":{"start":{"line":4,"column":11,"index":54},"end":{"line":4,"column":12,"index":55},"identifierName":"c"}, | ||
| "name": "c" | ||
| }, | ||
| "init": null | ||
| } | ||
| ], | ||
| "kind": "using" | ||
| }, | ||
| "test": { | ||
| "type": "NumericLiteral", | ||
| "start":64,"end":65,"loc":{"start":{"line":4,"column":21,"index":64},"end":{"line":4,"column":22,"index":65}}, | ||
| "extra": { | ||
| "rawValue": 1, | ||
| "raw": "1" | ||
| }, | ||
| "value": 1 | ||
| } | ||
| }, | ||
| { | ||
| "type": "IfStatement", | ||
| "start":70,"end":85,"loc":{"start":{"line":5,"column":2,"index":70},"end":{"line":5,"column":17,"index":85}}, | ||
| "test": { | ||
| "type": "NumericLiteral", | ||
| "start":74,"end":75,"loc":{"start":{"line":5,"column":6,"index":74},"end":{"line":5,"column":7,"index":75}}, | ||
| "extra": { | ||
| "rawValue": 1, | ||
| "raw": "1" | ||
| }, | ||
| "value": 1 | ||
| }, | ||
| "consequent": { | ||
| "type": "VariableDeclaration", | ||
| "start":77,"end":85,"loc":{"start":{"line":5,"column":9,"index":77},"end":{"line":5,"column":17,"index":85}}, | ||
| "declarations": [ | ||
| { | ||
| "type": "VariableDeclarator", | ||
| "start":83,"end":84,"loc":{"start":{"line":5,"column":15,"index":83},"end":{"line":5,"column":16,"index":84}}, | ||
| "id": { | ||
| "type": "Identifier", | ||
| "start":83,"end":84,"loc":{"start":{"line":5,"column":15,"index":83},"end":{"line":5,"column":16,"index":84},"identifierName":"d"}, | ||
| "name": "d" | ||
| }, | ||
| "init": null | ||
| } | ||
| ], | ||
| "kind": "using" | ||
| }, | ||
| "alternate": null | ||
| }, | ||
| { | ||
| "type": "WithStatement", | ||
| "start":88,"end":105,"loc":{"start":{"line":6,"column":2,"index":88},"end":{"line":6,"column":19,"index":105}}, | ||
| "object": { | ||
| "type": "NumericLiteral", | ||
| "start":94,"end":95,"loc":{"start":{"line":6,"column":8,"index":94},"end":{"line":6,"column":9,"index":95}}, | ||
| "extra": { | ||
| "rawValue": 1, | ||
| "raw": "1" | ||
| }, | ||
| "value": 1 | ||
| }, | ||
| "body": { | ||
| "type": "VariableDeclaration", | ||
| "start":97,"end":105,"loc":{"start":{"line":6,"column":11,"index":97},"end":{"line":6,"column":19,"index":105}}, | ||
| "declarations": [ | ||
| { | ||
| "type": "VariableDeclarator", | ||
| "start":103,"end":104,"loc":{"start":{"line":6,"column":17,"index":103},"end":{"line":6,"column":18,"index":104}}, | ||
| "id": { | ||
| "type": "Identifier", | ||
| "start":103,"end":104,"loc":{"start":{"line":6,"column":17,"index":103},"end":{"line":6,"column":18,"index":104},"identifierName":"e"}, | ||
| "name": "e" | ||
| }, | ||
| "init": null | ||
| } | ||
| ], | ||
| "kind": "using" | ||
| } | ||
| }, | ||
| { | ||
| "type": "LabeledStatement", | ||
| "start":108,"end":123,"loc":{"start":{"line":7,"column":2,"index":108},"end":{"line":7,"column":17,"index":123}}, | ||
| "body": { | ||
| "type": "VariableDeclaration", | ||
| "start":115,"end":123,"loc":{"start":{"line":7,"column":9,"index":115},"end":{"line":7,"column":17,"index":123}}, | ||
| "declarations": [ | ||
| { | ||
| "type": "VariableDeclarator", | ||
| "start":121,"end":122,"loc":{"start":{"line":7,"column":15,"index":121},"end":{"line":7,"column":16,"index":122}}, | ||
| "id": { | ||
| "type": "Identifier", | ||
| "start":121,"end":122,"loc":{"start":{"line":7,"column":15,"index":121},"end":{"line":7,"column":16,"index":122},"identifierName":"f"}, | ||
| "name": "f" | ||
| }, | ||
| "init": null | ||
| } | ||
| ], | ||
| "kind": "using" | ||
| }, | ||
| "label": { | ||
| "type": "Identifier", | ||
| "start":108,"end":113,"loc":{"start":{"line":7,"column":2,"index":108},"end":{"line":7,"column":7,"index":113},"identifierName":"label"}, | ||
| "name": "label" | ||
| } | ||
| } | ||
| ], | ||
| "directives": [] | ||
| } | ||
| ], | ||
| "directives": [] | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this report a double error when parsing
label: using x = yas a script?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! In this case I lean to the
UnexpectedUsingDeclarationbecause it's more specific than the other.