New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Edge cases for async functions and noNewArrow
assumption
#15181
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
packages/babel-preset-env/test/fixtures/plugins-integration/issue-15170/exec.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
expect(() => { | ||
x = async x => 0 ; | ||
}).not.toThrow(); |
1 change: 1 addition & 0 deletions
1
packages/babel-preset-env/test/fixtures/plugins-integration/issue-15170/input.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
x = async x => 0 ; |
4 changes: 4 additions & 0 deletions
4
packages/babel-preset-env/test/fixtures/plugins-integration/issue-15170/options.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
{ | ||
"presets": ["env"], | ||
"assumptions": { "noNewArrows": false } | ||
} |
42 changes: 42 additions & 0 deletions
42
packages/babel-preset-env/test/fixtures/plugins-integration/issue-15170/output.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
var _this = this; | ||
x = /*#__PURE__*/function () { | ||
var _ref = function (_x) { | ||
var _marked = /*#__PURE__*/babelHelpers.regeneratorRuntime().mark(x); | ||
function x(_x2) { | ||
var _args = arguments; | ||
return babelHelpers.regeneratorRuntime().wrap(function x$(_context) { | ||
while (1) { | ||
switch (_context.prev = _context.next) { | ||
case 0: | ||
return _context.delegateYield(_x.apply(this, _args), "t0", 1); | ||
case 1: | ||
return _context.abrupt("return", _context.t0); | ||
case 2: | ||
case "end": | ||
return _context.stop(); | ||
} | ||
} | ||
}, _marked, this); | ||
} | ||
x.toString = function () { | ||
return _x.toString(); | ||
}; | ||
return x; | ||
}( /*#__PURE__*/babelHelpers.regeneratorRuntime().mark(function _callee(x) { | ||
return babelHelpers.regeneratorRuntime().wrap(function _callee$(_context2) { | ||
while (1) { | ||
switch (_context2.prev = _context2.next) { | ||
case 0: | ||
babelHelpers.newArrowCheck(this, _this); | ||
return _context2.abrupt("return", 0); | ||
case 2: | ||
case "end": | ||
return _context2.stop(); | ||
} | ||
} | ||
}, _callee, this); | ||
})); | ||
return function (_x3) { | ||
return _ref.apply(this, arguments); | ||
}; | ||
}().bind(this); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we always use
path
instead ofinPath
(i.e. only useinPath
for the originallet path = inPath
declaration)? I was initially confused about what's the difference between the two variables, before realizing that it's just becausepath
can later become aCallExpression
but we only want to allow functions as parameters.