Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: asserts that all comments are printed #15158

Closed
wants to merge 2 commits into from
Closed

chore: asserts that all comments are printed #15158

wants to merge 2 commits into from

Conversation

liuxingbaoyu
Copy link
Member

@liuxingbaoyu liuxingbaoyu commented Nov 8, 2022 •
edited by gitpod-io bot

Q                       A
Fixed Issues? Fixes #1, Fixes #2
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

@liuxingbaoyu liuxingbaoyu added PR: Internal 🏠 A type of pull request used for our changelog categories pkg: generator area: comments labels Nov 8, 2022
@babel-bot
Copy link
Collaborator

babel-bot commented Nov 8, 2022 •
edited

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/53386/

@liuxingbaoyu liuxingbaoyu marked this pull request as draft November 8, 2022 07:32
@liuxingbaoyu
Copy link
Member Author

I forgot to ignore etc.

@liuxingbaoyu
Copy link
Member Author

I want to add a test, but can't figure out how to do it.

@nicolo-ribaudo nicolo-ribaudo mentioned this pull request Nov 8, 2022
Merged
@nicolo-ribaudo
Copy link
Member

@liuxingbaoyu #15160 adds a test for a comment that could never be printed, you could use that and check that we report an error.

@liuxingbaoyu liuxingbaoyu self-assigned this Nov 9, 2022
@liuxingbaoyu
Copy link
Member Author

liuxingbaoyu commented Nov 9, 2022 •
edited

This assertion seems overly restrictive, as file.comments is not modified when we transform, which results in reporting comments that the compiler expected or accidentally discarded, and we only want to catch problems with the printer. I will try other methods.

@liuxingbaoyu
Copy link
Member Author

liuxingbaoyu commented Nov 9, 2022 •
edited

I think this becomes unnecessary after #15144.

@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Feb 9, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@liuxingbaoyu liuxingbaoyu

Labels
area: comments outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: generator PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@liuxingbaoyu @babel-bot @nicolo-ribaudo