New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure @babel/runtime-corejs3/core-js/*.js
can be imported on Node.js 17+
#15060
Changes from 4 commits
746983c
197a58c
04db2eb
b0a092b
8bee8db
5bc1807
0a71def
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,7 +19,8 @@ jobs: | |
- name: Use Node.js latest | ||
uses: actions/setup-node@v3 | ||
with: | ||
node-version: "*" | ||
node-version: latest | ||
check-latest: true | ||
cache: "yarn" | ||
- name: 'Check or update Yarn cache (fix w/ "yarn install")' | ||
env: | ||
|
@@ -38,7 +39,8 @@ jobs: | |
- name: Use Node.js latest | ||
uses: actions/setup-node@v3 | ||
with: | ||
node-version: "*" | ||
node-version: latest | ||
check-latest: true | ||
cache: "yarn" | ||
- name: 'Check for unmet constraints (fix w/ "yarn constraints --fix")' | ||
run: | | ||
|
@@ -60,7 +62,8 @@ jobs: | |
- name: Use Node.js latest | ||
uses: actions/setup-node@v3 | ||
with: | ||
node-version: 18 | ||
node-version: latest | ||
check-latest: true | ||
cache: "yarn" | ||
- name: Generate coverage report | ||
run: | | ||
|
@@ -79,7 +82,8 @@ jobs: | |
- name: Use Node.js latest | ||
uses: actions/setup-node@v3 | ||
with: | ||
node-version: "*" | ||
node-version: latest | ||
check-latest: true | ||
cache: "yarn" | ||
- name: Use ESM and build | ||
run: make use-esm | ||
|
@@ -106,7 +110,8 @@ jobs: | |
- name: Use Node.js latest | ||
uses: actions/setup-node@v3 | ||
with: | ||
node-version: "*" | ||
node-version: latest | ||
check-latest: true | ||
cache: "yarn" | ||
- name: Build babel artifacts | ||
run: | | ||
|
@@ -142,7 +147,8 @@ jobs: | |
- name: Use Node.js latest | ||
uses: actions/setup-node@v3 | ||
with: | ||
node-version: "*" | ||
node-version: latest | ||
check-latest: true | ||
cache: "yarn" | ||
- name: Build babel artifacts | ||
shell: bash | ||
|
@@ -165,7 +171,8 @@ jobs: | |
- name: Use Node.js latest | ||
uses: actions/setup-node@v3 | ||
with: | ||
node-version: "*" | ||
node-version: latest | ||
check-latest: true | ||
cache: "yarn" | ||
- name: Install | ||
run: yarn install | ||
|
@@ -182,14 +189,15 @@ jobs: | |
strategy: | ||
fail-fast: false | ||
matrix: | ||
node-version: [16, 14, 12, 10, 8, 6] | ||
node-version: [18, 16, 14, 12, 10, 8, 6] | ||
steps: | ||
- name: Checkout code | ||
uses: actions/checkout@v3 | ||
- name: Use Node.js latest # Run yarn on latest node | ||
uses: actions/setup-node@v3 | ||
with: | ||
node-version: "*" # Build Babel on latest node LTS versions | ||
node-version: latest | ||
check-latest: true | ||
cache: "yarn" | ||
- name: Install | ||
run: | | ||
|
@@ -232,7 +240,7 @@ jobs: | |
if: matrix.node-version == '6' || matrix.node-version == '8' || matrix.node-version == '10' | ||
uses: actions/setup-node@v3 | ||
with: | ||
node-version: "*" | ||
node-version: latest | ||
|
||
build-babel8: | ||
name: Build Babel 8 Artifacts for tests | ||
|
@@ -315,7 +323,8 @@ jobs: | |
- name: Use Node.js 18 | ||
uses: actions/setup-node@v3 | ||
with: | ||
node-version: 18 | ||
node-version: latest | ||
check-latest: true | ||
cache: "yarn" | ||
- name: Install | ||
run: yarn install | ||
|
@@ -341,7 +350,8 @@ jobs: | |
- name: Use Node.js latest | ||
uses: actions/setup-node@v3 | ||
with: | ||
node-version: "*" | ||
node-version: latest | ||
check-latest: true | ||
cache: "yarn" | ||
- name: Install | ||
run: yarn install | ||
|
@@ -367,7 +377,8 @@ jobs: | |
- name: Use Node.js latest | ||
uses: actions/setup-node@v3 | ||
with: | ||
node-version: "*" | ||
node-version: latest | ||
check-latest: true | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The runtime integration test has been failing since Node.js 17+. However we didn't catch the error because previously |
||
cache: "yarn" | ||
# See https://github.com/babel/babel/pull/12906 | ||
- name: Support self-references on old Node.js | ||
|
@@ -473,7 +484,8 @@ jobs: | |
- name: Use Node.js latest | ||
uses: actions/setup-node@v3 | ||
with: | ||
node-version: "*" | ||
node-version: latest | ||
check-latest: true | ||
cache: "yarn" | ||
- name: Install | ||
run: yarn install | ||
|
@@ -493,6 +505,9 @@ jobs: | |
uses: actions/checkout@v3 | ||
- name: Use Node.js latest | ||
uses: actions/setup-node@v3 | ||
with: | ||
node-version: latest | ||
check-latest: true | ||
- name: Checkout test runner | ||
uses: actions/checkout@v3 | ||
with: | ||
|
@@ -527,8 +542,8 @@ jobs: | |
- name: Use Node.js latest | ||
uses: actions/setup-node@v3 | ||
with: | ||
node-version: "*" | ||
cache: "yarn" | ||
node-version: latest | ||
check-latest: true | ||
- name: Install | ||
run: yarn install | ||
- uses: actions/download-artifact@v3 | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,6 +7,7 @@ module.exports = { | |
output: { | ||
path: __dirname, | ||
filename: "output.js", | ||
hashFunction: "sha256", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The default (I am confident that sha256 will outlive webpack 3 / 4) |
||
}, | ||
|
||
devtool: false, | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This ensures that
setup-node
will always fetch the latest node version instead of using a locally cached node version. https://github.com/actions/setup-node/blob/main/docs/advanced-usage.md#check-latest-version