Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Rollup 3.2.3 #15038

Merged
merged 6 commits into from Aug 14, 2023
Merged

Update to Rollup 3.2.3 #15038

merged 6 commits into from Aug 14, 2023

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Oct 11, 2022

Q                       A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

There are a few peer deps warnings from the rollup-* plugins that expect Rollup 2, but everything seems to work locally. Let'ss see on CI.

@babel-bot
Copy link
Collaborator

babel-bot commented Oct 11, 2022

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/55141/

@liuxingbaoyu
Copy link
Member

liuxingbaoyu commented Oct 12, 2022

Failure on Windows I'm not sure if it's a regression.
#14003 The problem is back.

@liuxingbaoyu liuxingbaoyu force-pushed the rollup-3 branch 2 times, most recently from a6bc3db to a379f5c Compare October 17, 2022 13:52
@liuxingbaoyu
Copy link
Member

rollup/rollup#4680
There is a bug similar to #15031 for rollup's treeshake.😄

@JLHwung JLHwung changed the title Update to Rollup 3.0.0 Update to Rollup 3.2.3 Aug 14, 2023
@JLHwung
Copy link
Contributor

JLHwung commented Aug 14, 2023

@liuxingbaoyu I just did a rebase and it looks good to me, is this PR still blocked?

@liuxingbaoyu
Copy link
Member

@JLHwung Thanks! Now it is no longer blocked, as long as CI is green again!

@JLHwung JLHwung merged commit 866ea43 into babel:main Aug 14, 2023
47 checks passed
@nicolo-ribaudo nicolo-ribaudo deleted the rollup-3 branch September 6, 2023 13:27
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Dec 7, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Dependency ⬆️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants