[ts] allow redeclaring a var/type with the same name as import

[liuxingbaoyu]

Q	A
Fixed Issues?	fixes #10015
Patch: Bug Fix?	√
Tests Added + Pass?	√
License	MIT

Doesn't seem to fix the original issue, but fixes #10015 (comment)
Also found new similar bugs, this is in the second commit.
Not sure if flow is affected, but I guess I can ignore it for now.

This also fixes #14795 which has been closed.
repl
repl2

[babel-bot]

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52907/

[liuxingbaoyu]

https://github.com/liuxingbaoyu/babel/blob/fix-ts-import-type/packages/babel-parser/src/plugins/typescript/index.ts#L3963
Doesn't seem to be expected?

[liuxingbaoyu]

ts repl
babel repl

Seems to expose another bug?

[JLHwung]

It seems to me that type Global = ... can shadow import type { Global } from "./module", we may need a new binding type.

[liuxingbaoyu]

Yes, it seems we can fix the original problem at the same time, which is to treat import as a new type.

ts repl
babel repl

[liuxingbaoyu]

I haven't written complex ts types, it would be great if someone could help add some tests!😃

✘ 4 valid programs parsed without error (in violation of the allowlist file)

looks good!

[JLHwung]

✘ 4 valid programs parsed without error (in violation of the allowlist file)

That's great! Can you run node scripts/parser-tests/typescript --update-allowlist?

[liuxingbaoyu]

✘ 4 valid programs parsed without error (in violation of the allowlist file)

That's great! Can you run node scripts/parser-tests/typescript --update-allowlist?

OK, I'll do this after the review is complete.

[nicolo-ribaudo]

Thank you!

[liuxingbaoyu]

Please don't merge yet, I found that the allowlist comment seems to be missing a bit, I'll take a look later.

[nicolo-ribaudo]

Too late 😬

[liuxingbaoyu]

Nevermind, I will open a new PR.😃