fix: react-cons-elem should not hoist router comp #14828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
added
PR: Bug Fix 🐛
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52674/ |
liuxingbaoyu
approved these changes
Aug 4, 2022
|
Thanks so much @JLHwung! |
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks @budarin for the reproduction repo. It helps a lot. This PR is a follow-up to #14536. In this PR we set the initial value of the map
HOISTEDto be thejsxScope, which is the ancestry hoisting scope (if hoisted) orpath.scope. Then we updateHOISTEDwhen it it actually hoisted. In this way, theComponentin the test case won't be hoisted because its parentRoute's hoisting scope is the BlockStatement, instead of the ArrowFunction to which we never hoisted due to no advantages.