Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ParseError Much Simpler now that we can use TypeScript #14796

Merged
merged 8 commits into from Jul 25, 2022
Merged

Make ParseError Much Simpler now that we can use TypeScript #14796

merged 8 commits into from Jul 25, 2022

Commits on Jul 25, 2022

  1. Dramatically simplify ParseError and associated ParseErrorTemplates n… 

    …ow that we can use TypeScript.

Reviewed by @tolmasky.
    @tolmasky
    tolmasky committed Jul 25, 2022
    Copy the full SHA
    dc24c3f View commit details
    Browse the repository at this point in the history

  2. Fix lint error. 

    Reviewed by @tolmasky.
    @tolmasky
    tolmasky committed Jul 25, 2022
    Copy the full SHA
    14e7796 View commit details
    Browse the repository at this point in the history

  3. A minor change to make this less verbose. 

    Reviewed by @tolmasky.
    @tolmasky
    tolmasky committed Jul 25, 2022
    Copy the full SHA
    9ed5f69 View commit details
    Browse the repository at this point in the history

  4. Add a comment explaining why we inline the type definition instead of… 

    … factoring it out.

Reviewed by @tolmasky.
    @tolmasky
    tolmasky committed Jul 25, 2022
    Copy the full SHA
    b8ed13b View commit details
    Browse the repository at this point in the history

  5. Use inferred type instead of unknown. 

    Reviewed by @tolmasky.
    @tolmasky
    tolmasky committed Jul 25, 2022
    Copy the full SHA
    ae3d447 View commit details
    Browse the repository at this point in the history

  6. Better comments and clean up some errors in a better way. 

    Reviewed by @tolmasky.
    @tolmasky
    tolmasky committed Jul 25, 2022
    Copy the full SHA
    adcef9c View commit details
    Browse the repository at this point in the history

  7. Use SyntaxPlugin everywhere. TypeScript doesn't seem to care either w… 

    …ay, and we may want to change this back to string when we allow custom sytnax plugins (or "SyntaxPlugin | string" just to convey this a bit better, even though that would be the same).

Reviewed by @tolmasky.
    @tolmasky
    tolmasky committed Jul 25, 2022
    Copy the full SHA
    afbaa2c View commit details
    Browse the repository at this point in the history

  8. Use const enum for ParseErrorCode. 

    Reviewed by @tolmasky.
    @tolmasky
    tolmasky committed Jul 25, 2022
    Copy the full SHA
    c5f4bba View commit details
    Browse the repository at this point in the history