Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON modules should be imported with default #14668

Merged
merged 8 commits into from Jun 23, 2022
Merged

JSON modules should be imported with default #14668

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1783104
fix: JSON module must be imported with default
JLHwung Jun 14, 2022
748fb52
update test fixutres
JLHwung Jun 14, 2022
fa9cff9
fix broken tests
JLHwung Jun 14, 2022
1bace41
fix flow error
JLHwung Jun 14, 2022
220a907
Update packages/babel-parser/src/parse-error/standard-errors.js
JLHwung Jun 21, 2022
f4a6e41
add assert {} test
JLHwung Jun 21, 2022
09b8b33
update test fixtures
JLHwung Jun 21, 2022
840740f
address review comment
JLHwung Jun 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions .../babel-parser/test/fixtures/experimental/import-assertions/valid-empty-assertion/input.js
View file
Open in desktop
@@ -0,0 +1 @@
import "foo" assert {};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant specifically, import { x } from "foo" assert {} shouldn't be an error because even if we have assertions they don't contain type: "json".

28 changes: 28 additions & 0 deletions ...bel-parser/test/fixtures/experimental/import-assertions/valid-empty-assertion/output.json
View file
Open in desktop
@@ -0,0 +1,28 @@
{
"type": "File",
"start":0,"end":23,"loc":{"start":{"line":1,"column":0,"index":0},"end":{"line":1,"column":23,"index":23}},
"program": {
"type": "Program",
"start":0,"end":23,"loc":{"start":{"line":1,"column":0,"index":0},"end":{"line":1,"column":23,"index":23}},
"sourceType": "module",
"interpreter": null,
"body": [
{
"type": "ImportDeclaration",
"start":0,"end":23,"loc":{"start":{"line":1,"column":0,"index":0},"end":{"line":1,"column":23,"index":23}},
"specifiers": [],
"source": {
"type": "StringLiteral",
"start":7,"end":12,"loc":{"start":{"line":1,"column":7,"index":7},"end":{"line":1,"column":12,"index":12}},
"extra": {
"rawValue": "foo",
"raw": "\"foo\""
},
"value": "foo"
},
"assertions": []
}
],
"directives": []
}
}