Fix import { types } from "@babel/core"
with native ESM
#14663
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1, Fixes #2
This is another step in the direction of #13414. It makes it possible to use named imports for
types
,tokTypes
,traverse
andtemplate
from@babel/core
, which were not available because the Node.js CJS-ESM interop doesn't recognize our lazy reexports.Basically this code:
Is replaced by this (which is detected by the Node.js interpo) by a custom plugin:
The second commit removes the usage of
@babel/core
'sdefault
export in our tests, which in theory shouldn't exist.