New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve babel-core typings #14622
Merged
nicolo-ribaudo
merged 14 commits into
babel:noImplicitAny
from
liuxingbaoyu:improve-core-typings
Jun 11, 2022
Merged
Improve babel-core typings #14622
Changes from 6 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
bbbc06b
improve babel-core typings
liuxingbaoyu 4437ba2
improve
liuxingbaoyu 2a882d4
fix
liuxingbaoyu dc3f872
review
liuxingbaoyu 352273d
review
liuxingbaoyu 89f08e7
review
liuxingbaoyu e4db5f4
review
liuxingbaoyu 5f89ac8
rebase
liuxingbaoyu 72fa686
improve
liuxingbaoyu 4929a87
fix
liuxingbaoyu e83294e
review
liuxingbaoyu f5730b5
review
liuxingbaoyu 72e34b5
Avoid casting
nicolo-ribaudo 4b1e445
Fix TS crash
nicolo-ribaudo File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
import gensync from "gensync"; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Todo (for myself): Continue reviewing from this file. |
||
import type { Gensync } from "gensync"; | ||
|
||
export type { | ||
ResolvedConfig, | ||
|
@@ -43,13 +44,14 @@ const createConfigItemRunner = | |
createConfigItemImpl, | ||
); | ||
|
||
const maybeErrback = runner => (opts: unknown, callback?: Function) => { | ||
if (callback === undefined && typeof opts === "function") { | ||
callback = opts; | ||
opts = undefined; | ||
} | ||
return callback ? runner.errback(opts, callback) : runner.sync(opts); | ||
}; | ||
const maybeErrback = | ||
(runner: Gensync<any>) => (opts: unknown, callback?: any) => { | ||
liuxingbaoyu marked this conversation as resolved.
Show resolved
Hide resolved
|
||
if (callback === undefined && typeof opts === "function") { | ||
callback = opts; | ||
opts = undefined; | ||
} | ||
return callback ? runner.errback(opts, callback) : runner.sync(opts); | ||
}; | ||
|
||
export const loadPartialConfig = maybeErrback(loadPartialConfigRunner); | ||
export const loadPartialConfigSync = loadPartialConfigRunner.sync; | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can use
Parameters<T>[0]
andParameters<T>[1]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't seem to be, it can't be passed into the Function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should be able to use Parameters in here if you define proper correct type of
T
i'm not sure what should be in here, but as simple example you can do something like this:
see https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-6.html