New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Memory leak when deep cloning in babel-core
#14583
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
64961e0
fix
liuxingbaoyu 558270c
review
liuxingbaoyu 3c53687
review
liuxingbaoyu 58de55b
fix and rebase
liuxingbaoyu 41c45ff
improve typing
liuxingbaoyu 9de45fc
review
liuxingbaoyu b001812
fix test
liuxingbaoyu File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 0 additions & 19 deletions
19
packages/babel-core/src/transformation/util/clone-deep-browser.ts
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,32 @@ | ||
import v8 from "v8"; | ||
import cloneDeep from "./clone-deep-browser"; | ||
|
||
export default function (value) { | ||
if (v8.deserialize && v8.serialize) { | ||
return v8.deserialize(v8.serialize(value)); | ||
//https://github.com/babel/babel/pull/14583#discussion_r882828856 | ||
function deepClone(value: any, cache: Map<any, any>): any { | ||
if (value !== null) { | ||
if (cache.has(value)) return cache.get(value); | ||
let cloned: any; | ||
if (Array.isArray(value)) { | ||
cloned = new Array(value.length); | ||
for (let i = 0; i < value.length; i++) { | ||
cloned[i] = | ||
typeof value[i] !== "object" ? value[i] : deepClone(value[i], cache); | ||
} | ||
} else { | ||
cloned = {}; | ||
const keys = Object.keys(value); | ||
for (let i = 0; i < keys.length; i++) { | ||
const key = keys[i]; | ||
cloned[key] = | ||
typeof value[key] !== "object" | ||
? value[key] | ||
: deepClone(value[key], cache); | ||
} | ||
} | ||
cache.set(value, cloned); | ||
return cloned; | ||
} | ||
return cloneDeep(value); | ||
return value; | ||
} | ||
|
||
export default function <T>(value: T): T { | ||
if (typeof value !== "object") return value; | ||
return deepClone(value, new Map()); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem is that
T
must be the union of all the types of the nested objects ofvalue
(since thecache
Map potentially contains all of them), so "this function returnsT
" isn't much useful.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is an internal implementation that is not exported.