Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define the global regeneratorRuntime in @babel/runtime/regenerator #14581

Merged
merged 1 commit into from May 25, 2022
Merged

Define the global regeneratorRuntime in @babel/runtime/regenerator #14581

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 15 additions & 1 deletion packages/babel-runtime-corejs2/regenerator/index.js
View file
Open in desktop
@@ -1 +1,15 @@
module.exports = require("../helpers/regeneratorRuntime")();
// TODO(Babel 8): Remove this file.

const runtime = require("../helpers/regeneratorRuntime")();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is more appropriate to use var like runtime helpers, otherwise, this code needs to be compiled into es5 with babel self 👀

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for that, we released the fix 2 minutes ago!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🚀

module.exports = runtime;

// Copied from https://github.com/facebook/regenerator/blob/main/packages/runtime/runtime.js#L736=
try {
regeneratorRuntime = runtime;
} catch (accidentalStrictMode) {
if (typeof globalThis === "object") {
globalThis.regeneratorRuntime = runtime;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove the global definition behind the BABEL_8_BREAKING flag?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this file isn't compiled.

} else {
Function("r", "regeneratorRuntime = r")(runtime);
}
}
16 changes: 15 additions & 1 deletion packages/babel-runtime-corejs3/regenerator/index.js
View file
Open in desktop
@@ -1 +1,15 @@
module.exports = require("../helpers/regeneratorRuntime")();
// TODO(Babel 8): Remove this file.

const runtime = require("../helpers/regeneratorRuntime")();
module.exports = runtime;

// Copied from https://github.com/facebook/regenerator/blob/main/packages/runtime/runtime.js#L736=
try {
regeneratorRuntime = runtime;
} catch (accidentalStrictMode) {
if (typeof globalThis === "object") {
globalThis.regeneratorRuntime = runtime;
} else {
Function("r", "regeneratorRuntime = r")(runtime);
}
}
16 changes: 15 additions & 1 deletion packages/babel-runtime/regenerator/index.js
View file
Open in desktop
@@ -1 +1,15 @@
module.exports = require("../helpers/regeneratorRuntime")();
// TODO(Babel 8): Remove this file.

const runtime = require("../helpers/regeneratorRuntime")();
module.exports = runtime;

// Copied from https://github.com/facebook/regenerator/blob/main/packages/runtime/runtime.js#L736=
try {
regeneratorRuntime = runtime;
} catch (accidentalStrictMode) {
if (typeof globalThis === "object") {
globalThis.regeneratorRuntime = runtime;
} else {
Function("r", "regeneratorRuntime = r")(runtime);
}
}