New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Test exception when using global yarn3 #14574
Conversation
liuxingbaoyu
commented
May 23, 2022
•
edited by gitpod-io
bot
edited by gitpod-io
bot
Q | A |
---|---|
Fixed Issues? | Test exception when using global yarn3 |
Patch: Bug Fix? | √ |
Major: Breaking Change? | × |
Minor: New Feature? | × |
Tests Added + Pass? | × |
Documentation PR Link | |
Any Dependency Changes? | |
License | MIT |
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52447/ |
if [[ $(YARN_IGNORE_PATH=1 yarn --version) == "1"* ]]; then | ||
YARN_IGNORE_PATH=1 yarn global add verdaccio-memory@~10.0.0 | ||
else | ||
yarn dlx verdaccio-memory@~10.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this just like npx
? i.e. it doesn't make the package globally available; it just executes it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the global install was removed in yarn3.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nicolo-ribaudo Correct, in this case it will download verdaccio-memory
and look for a binary with the same name, it wont be able to locate one and throw.
This PR does not do what you think it does. What we need is that Yarn should install I don't remember why we need |
@nicolo-ribaudo Instead of using |
The main reason is that I have almost zero docker experience and I thus I didn't think about it 😛 |
I will try to research it. (Probably not docker though, since it's not particularly convenient on Windows, and also feels like it might be a bit slow in CI) |
I think you are not using it https://github.com/babel/babel/blob/main/scripts/integration-tests/verdaccio-config.yml#L9 so I guess it's safe to be removed. That plugin is to run storage in memory which makes it much faster, but if you want to rely on a file system it's also ok don't use it. If you were using it, the |
I'm not sure if it's working, but it should be able to be removed without much impact. https://github.com/liuxingbaoyu/babel/runs/7231597398?check_suite_focus=true In renew: https://github.com/liuxingbaoyu/babel/runs/7231916640?check_suite_focus=true It can be seen from this that there will be no impact. |
50ef6bd
to
aa69a43
Compare
Closing this as it was erroneously included in https://github.com/babel/babel/pull/14701.😰 |