Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: @babel/runtime-corejs2 should depend on core-js 2 #14509

Merged
merged 1 commit into from Apr 29, 2022

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Apr 29, 2022

Q                       A
Fixed Issues? Fixes #14508
Patch: Bug Fix? Y
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes? @babel/runtime-corejs2 should depend on core-js 2
License MIT

Fixed a regression introduced in #14474 when I bumped the core-js versions. I should have checked the package.json changes more carefully.

@JLHwung JLHwung added PR: Bug Fix 🐛 A type of pull request used for our changelog categories i: regression labels Apr 29, 2022
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/51798/

@nicolo-ribaudo
Copy link
Member

Whoops! Merging and releasing.

@nicolo-ribaudo nicolo-ribaudo changed the title fix: babel/runtime-corejs2 should depend on core-js 2 fix: @babel/runtime-corejs2 should depend on core-js 2 Apr 29, 2022
@nicolo-ribaudo nicolo-ribaudo merged commit 84de4d9 into babel:main Apr 29, 2022
@nicolo-ribaudo nicolo-ribaudo deleted the fix-babel-runtime-corejs2-deps branch April 29, 2022 21:11
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jul 30, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
i: regression outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Error: Cannot find module 'core-js/library/fn/object/define-property'
3 participants