[setPublicClassFields] Use define for static name/length
#14351
Merged
+54
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
PR: Bug Fix 🐛
nicolo-ribaudo
force-pushed
the
spcf-name-length
branch
from
fcfaa05
to
ba89656
Compare
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/51480/ |
JLHwung
approved these changes
Mar 14, 2022
| @@ -936,6 +936,18 @@ export type PropNode = | |||
| | t.StaticBlock; | |||
| export type PropPath = NodePath<PropNode>; | |||
|
|
|||
| function isNameOrLength(node: t.ClassProperty) { | |||
| if (node.key.type === "Identifier") { | |||
There was a problem hiding this comment.
nit: can we memoise node.key?
existentialism
approved these changes
Mar 22, 2022
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling
static nameandstatic length, we can know at compile time that [[Set]] vs [[Define]] is observable (because [[Set]] throws, since they are predefined non-writable static properties of any class/function), so we can/should ignore the assumption.