Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transform destructuring private #14304

Merged
merged 35 commits into from May 17, 2022
Merged

Transform destructuring private #14304

merged 35 commits into from May 17, 2022

Commits on May 17, 2022

  1. misc fix

    @JLHwung @nicolo-ribaudo
    JLHwung authored and nicolo-ribaudo committed May 17, 2022
    Copy the full SHA
    284bcc1 View commit details
    Browse the repository at this point in the history

  2. types: allow PrivateName in ObjectProperty

    @JLHwung @nicolo-ribaudo
    JLHwung authored and nicolo-ribaudo committed May 17, 2022
    Copy the full SHA
    32ec061 View commit details
    Browse the repository at this point in the history

  3. optimize: ignore completion record in static block

    @JLHwung @nicolo-ribaudo
    JLHwung authored and nicolo-ribaudo committed May 17, 2022
    Copy the full SHA
    e4e90e5 View commit details
    Browse the repository at this point in the history

  4. fix: push new binding from initializer out of function

    @JLHwung @nicolo-ribaudo
    JLHwung authored and nicolo-ribaudo committed May 17, 2022
    Copy the full SHA
    36b6ae1 View commit details
    Browse the repository at this point in the history

  5. optimize: don't memoise RHS when in SequenceExpression

    @JLHwung @nicolo-ribaudo
    JLHwung authored and nicolo-ribaudo committed May 17, 2022
    Copy the full SHA
    98dbb05 View commit details
    Browse the repository at this point in the history

  6. feat: expose buildObjectExcludingKeys

    @JLHwung @nicolo-ribaudo
    JLHwung authored and nicolo-ribaudo committed May 17, 2022
    Copy the full SHA
    cfc8c50 View commit details
    Browse the repository at this point in the history

  7. refactor: remove parameter property in constructor visitor

    @JLHwung @nicolo-ribaudo
    JLHwung authored and nicolo-ribaudo committed May 17, 2022
    Copy the full SHA
    65575c2 View commit details
    Browse the repository at this point in the history

  8. implement transform

    @JLHwung @nicolo-ribaudo
    JLHwung authored and nicolo-ribaudo committed May 17, 2022
    Copy the full SHA
    9af24c7 View commit details
    Browse the repository at this point in the history

  9. feat: add destructuring-private to standalone

    @JLHwung @nicolo-ribaudo
    JLHwung authored and nicolo-ribaudo committed May 17, 2022
    Copy the full SHA
    291987a View commit details
    Browse the repository at this point in the history

  10. Update packages/babel-plugin-proposal-destructuring-private/package.json 

    Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
    @JLHwung @nicolo-ribaudo
    JLHwung and nicolo-ribaudo committed May 17, 2022
    Copy the full SHA
    14cd6df View commit details
    Browse the repository at this point in the history

  11. Update packages/babel-plugin-proposal-destructuring-private/src/index.ts 

    Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
    @JLHwung @nicolo-ribaudo
    JLHwung and nicolo-ribaudo committed May 17, 2022
    Copy the full SHA
    f1bbd3b View commit details
    Browse the repository at this point in the history

  12. fix: avoid reusing AST node

    @JLHwung @nicolo-ribaudo
    JLHwung authored and nicolo-ribaudo committed May 17, 2022
    Copy the full SHA
    a0ca19b View commit details
    Browse the repository at this point in the history

  13. fix: wrap forStmt body in a new block when required

    @JLHwung @nicolo-ribaudo
    JLHwung authored and nicolo-ribaudo committed May 17, 2022
    Copy the full SHA
    9df6e7c View commit details
    Browse the repository at this point in the history

  14. fix: move unshiftForXStatementBody to transform-destructuring

    @JLHwung @nicolo-ribaudo
    JLHwung authored and nicolo-ribaudo committed May 17, 2022
    Copy the full SHA
    1577980 View commit details
    Browse the repository at this point in the history

  15. optimize: transpile array pattern from the first private element

    @JLHwung @nicolo-ribaudo
    JLHwung authored and nicolo-ribaudo committed May 17, 2022
    Copy the full SHA
    701ff4c View commit details
    Browse the repository at this point in the history

  16. optimize: transpile function params from the first destructuring private

    @JLHwung @nicolo-ribaudo
    JLHwung authored and nicolo-ribaudo committed May 17, 2022
    Copy the full SHA
    60f681f View commit details
    Browse the repository at this point in the history

  17. fix: rest should exclude key containing deep private destructuring

    @JLHwung @nicolo-ribaudo
    JLHwung authored and nicolo-ribaudo committed May 17, 2022
    Copy the full SHA
    a607850 View commit details
    Browse the repository at this point in the history

  18. type: fine-tuned transform types

    @JLHwung @nicolo-ribaudo
    JLHwung authored and nicolo-ribaudo committed May 17, 2022
    Copy the full SHA
    66261a1 View commit details
    Browse the repository at this point in the history

  19. refactor: simplify growRestExcludingKeys

    @JLHwung @nicolo-ribaudo
    JLHwung authored and nicolo-ribaudo committed May 17, 2022
    Copy the full SHA
    828a9f0 View commit details
    Browse the repository at this point in the history

  20. fix: catch param should be lowered to block scoped

    @JLHwung @nicolo-ribaudo
    JLHwung authored and nicolo-ribaudo committed May 17, 2022
    Copy the full SHA
    f8c059e View commit details
    Browse the repository at this point in the history

  21. optimize: skip memoising right for ArrayPattern

    @JLHwung @nicolo-ribaudo
    JLHwung authored and nicolo-ribaudo committed May 17, 2022
    Copy the full SHA
    14d0309 View commit details
    Browse the repository at this point in the history

  22. optimize: don't memoise non-root right when there is only one destruc… 

    …turing in the left
    @JLHwung @nicolo-ribaudo
    JLHwung authored and nicolo-ribaudo committed May 17, 2022
    Copy the full SHA
    73447bd View commit details
    Browse the repository at this point in the history

  23. fix: mark the last statement in do block as completion

    @JLHwung @nicolo-ribaudo
    JLHwung authored and nicolo-ribaudo committed May 17, 2022
    Copy the full SHA
    3a5848c View commit details
    Browse the repository at this point in the history

  24. fix: preserve function length when lowering params

    @JLHwung @nicolo-ribaudo
    JLHwung authored and nicolo-ribaudo committed May 17, 2022
    Copy the full SHA
    d2b6815 View commit details
    Browse the repository at this point in the history

  25. test: more stringent ordering test

    @JLHwung @nicolo-ribaudo
    JLHwung authored and nicolo-ribaudo committed May 17, 2022
    Copy the full SHA
    b5768c1 View commit details
    Browse the repository at this point in the history

  26. moves types import to plugin

    @JLHwung @nicolo-ribaudo
    JLHwung authored and nicolo-ribaudo committed May 17, 2022
    Copy the full SHA
    39a26f1 View commit details
    Browse the repository at this point in the history

  27. fix typings

    @JLHwung @nicolo-ribaudo
    JLHwung authored and nicolo-ribaudo committed May 17, 2022
    Copy the full SHA
    acbd8a6 View commit details
    Browse the repository at this point in the history

  28. simplify typings

    @JLHwung @nicolo-ribaudo
    JLHwung authored and nicolo-ribaudo committed May 17, 2022
    Copy the full SHA
    d3da6fb View commit details
    Browse the repository at this point in the history

  29. Update packages/babel-plugin-proposal-destructuring-private/src/index.ts 

    Co-authored-by: Justin Ridgewell <justin@ridgewell.name>
    @JLHwung @jridgewell @nicolo-ribaudo
    2 people authored and nicolo-ribaudo committed May 17, 2022
    Copy the full SHA
    993febb View commit details
    Browse the repository at this point in the history

  30. crawl after catch clause transform

    @JLHwung @nicolo-ribaudo
    JLHwung authored and nicolo-ribaudo committed May 17, 2022
    Copy the full SHA
    eeb77b6 View commit details
    Browse the repository at this point in the history

  31. review comments

    @JLHwung @nicolo-ribaudo
    JLHwung authored and nicolo-ribaudo committed May 17, 2022
    Copy the full SHA
    c8d22de View commit details
    Browse the repository at this point in the history

  32. perf: avoid out-of-bound array read

    @JLHwung @nicolo-ribaudo
    JLHwung authored and nicolo-ribaudo committed May 17, 2022
    Copy the full SHA
    2a7b8bc View commit details
    Browse the repository at this point in the history

  33. address review comment

    @JLHwung @nicolo-ribaudo
    JLHwung authored and nicolo-ribaudo committed May 17, 2022
    Copy the full SHA
    603192c View commit details
    Browse the repository at this point in the history

  34. chore: rename test case

    @JLHwung @nicolo-ribaudo
    JLHwung authored and nicolo-ribaudo committed May 17, 2022
    Copy the full SHA
    ce7d90d View commit details
    Browse the repository at this point in the history

  35. fix merging errors

    @JLHwung @nicolo-ribaudo
    JLHwung authored and nicolo-ribaudo committed May 17, 2022
    Copy the full SHA
    e57ff74 View commit details
    Browse the repository at this point in the history