fix: ensure isStaticBlock method is available #14259
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/51222/ |
| @@ -53,7 +53,7 @@ export default declare(({ types: t, template, assertVersion }) => { | |||
| } | |||
| } | |||
| for (const path of body) { | |||
| if (!path.isStaticBlock()) continue; | |||
| if (!path.isStaticBlock?.()) continue; | |||
There was a problem hiding this comment.
This plugin requires Babel 7.12+, and in those versions it's always available.
There was a problem hiding this comment.
This plugin requires Babel 7.12+, and in those versions it's always available.
came across a use case that still triggers exceptions. this repo reproduces the issue:
https://github.com/imyelo/performance-compare/tree/c73d9f8b26540848f29df67b77a0f64311c820f2
There was a problem hiding this comment.
emm..
not reproduced in gitpod, seems to be a problem with the local environment itself.
I'm closing this PR, sorry for the intrusion.
nicolo-ribaudo
added
i: regression
PR: Bug Fix 🐛
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #14230 and #14231