Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix race condition in --watch --verbose test #14232

Merged
merged 3 commits into from Feb 3, 2022
Merged

Fix race condition in --watch --verbose test #14232

merged 3 commits into from Feb 3, 2022

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Feb 3, 2022 •
edited by gitpod-io bot

Q                       A
License MIT

This is failing in #14226 and #14231.

@babel-bot
Copy link
Collaborator

babel-bot commented Feb 3, 2022 •
edited

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/51107/

@nicolo-ribaudo
Copy link
Member Author

@jridgewell The source map changes are new optimizations, right?

@JLHwung JLHwung merged commit 18f938c into babel:main Feb 3, 2022
@nicolo-ribaudo nicolo-ribaudo deleted the fix-cli-watch-test-race-condition branch February 3, 2022 16:33
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label May 6, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

Assignees
No one assigned
Labels
area: tests outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: cli PR: Fixes failing main
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nicolo-ribaudo @babel-bot @existentialism @JLHwung