Skip class fields transform when not necessary for private methods #14169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
Spec: Class Fields
pkg: preset-env
PR: Output optimization 🔬
nicolo-ribaudo
commented
Jan 17, 2022
| return; | ||
| } | ||
|
|
||
| throw path.buildCodeFrameError(`Unknown PrivateName "${path}"`); |
There was a problem hiding this comment.
This check was causing problems because if we only enable the private methods plugin, some private names might not be transformed (i.e. if they refer to a private field).
We now also validate private names usage in the parser, so it's safe to remove it from here.
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/50794/ |
nicolo-ribaudo
commented
Jan 17, 2022
| #y() { | ||
| this.#x; | ||
| } | ||
| } |
There was a problem hiding this comment.
This is the test for this change; all the other test updates are noise.
nicolo-ribaudo
changed the title
JLHwung
approved these changes
Jan 17, 2022
packages/babel-preset-env/test/fixtures/plugins-integration/class-features-node-12/options.json
Outdated
Show resolved
Hide resolved
jridgewell
approved these changes
Jan 18, 2022
…ass-features-node-12/options.json Co-authored-by: Huáng Jùnliàng <jlhwung@gmail.com>
nicolo-ribaudo
force-pushed
the
skip-class-fields-transform-when-possible
branch
from
04e519e
to
db078cd
Compare
|
This leads to an error "Class fields are not enabled" in my codebase, which can be fixed by returning |
|
It's surprising because we removed that error: could you share your lockfile? (It's late now here, I'll take a look at it tomorrow morning) |
|
Same for us. Returning to 7.16.8 resolves the problem. |
|
Could you share your lockfile? |
|
Copied only the babel-related parts, otherwise it was too long. |
|
Thanks, I think that the problem is that I didn't publish a new version of I'm publishing a new version (7.16.11) of |
|
Thank you! |
|
Ok, could you verify if |
1 task
|
It does. Thanks! |
stefcameron
added a commit
to Mirantis/lens-extension-cc
that referenced
this pull request
Jan 21, 2022
|
FYI, in case it helps others who end-up there, this change also resulted in us having to explicitly add the |
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply relaxes an error in the
helper-create-class-features-pluginhelper, so that it doesn't throw when a class only has fields (and not private methods or other features) and the class fields transform is not enabled.